Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

invenio-cli assets watch not compiling LESS files on repeated changes #2557

Open
daglueck opened this issue Dec 21, 2023 · 2 comments · May be fixed by inveniosoftware/invenio-assets#166
Open
Labels
bug Something isn't working

Comments

@daglueck
Copy link

daglueck commented Dec 21, 2023

Package version (if known): 12.0.0b2.dev66
Python version: 3.9.18
Node version: 16.20.2
NPM version: 7.24.2
invenio-cli version: 1.2.0

Describe the bug

When changing a LESS file (hosted within the assets/less directory) and saving it, invenio-cli assets watch recompiles the LESS assets. However, when doing this repeatedly, it seems to recompile effectively only on first change, not on subsequent changes. Although subsequent changes also trigger a recompilation according to terminal output, they don't seem to come into effect; interestingly, the duration of compilations on subsequent changes is also very short in comparison to the first change's compilation.

Steps to Reproduce

I'm taking zenodo-rdm as a public repository for reproducing the error, but it also appeared in a private InvenioRDM instance.

  1. Checkout zenodo-rdm and install and run it according to the instructions.
  2. In a new terminal, run invenio-cli assets watch.
  3. Change a LESS rule, e.g. increase the minimum height of the navbar to 400px and save the file. This will succesfully recompile and the change can be seen on the instance's frontpage (https://127.0.0.1/).
  4. Now change the same LESS rule, e.g. increase the height to 800px, and save the file again. Terminal output says something like webpack ... compiled successfully in ... ms, but when reloading the page, the changes haven't come into effect. Also notice the much shorter compilation time than in step 3.

Expected behavior

invenio-cli assets watch should recompile repeatedly when changing a file multiple times, not just upon first change.

Additional context

This issue also has been discussed on Discord and it seems to apply to multiple of the later invenio-app-rdm v12 beta versions. I'm not sure if it only applies to LESS or also to other types of assets, I've only tested it with LESS files.

@daglueck daglueck added the bug Something isn't working label Dec 21, 2023
Copy link
Contributor

This issue was automatically marked as stale.

@github-actions github-actions bot added the stale No activity for more than 60 days. label Feb 20, 2024
@Samk13 Samk13 removed the stale No activity for more than 60 days. label Feb 20, 2024
Copy link
Contributor

This issue was automatically marked as stale.

@github-actions github-actions bot added the stale No activity for more than 60 days. label Apr 21, 2024
@Samk13 Samk13 removed the stale No activity for more than 60 days. label Apr 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants