Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker image cannot be built without preliminar steps #245

Open
avivace opened this issue Nov 2, 2022 · 0 comments
Open

Docker image cannot be built without preliminar steps #245

avivace opened this issue Nov 2, 2022 · 0 comments
Labels
bug Something isn't working

Comments

@avivace
Copy link
Member

avivace commented Nov 2, 2022

I find it a bit confusing that, at the moment, the shipped Dockerfile cannot be used to build an image, but it first requires preliminar steps (invenio-cli install, even if some steps e.g. pipenv install dependencies are duplicated and some are not e.g. the webpack build is just copied).
I think it should be at least mentioned (at least till we ship a proper application image, but even then, it will depend on how many of those values are modifiable or need to be passed to steps that need to be run before the docker build).

@avivace avivace added the bug Something isn't working label Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant