config: set default preview image size limit to 5mb #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Question: Is the 5mb for the IIIF previewer? |
|
No, the IIIF previewer is deactivated by default because of inveniosoftware/invenio-iiif#43. i.e. it works externally but seems not to work for the landing page? Dan might have more details. This limit is for the We might want to remove the config variable once the IIIF is working. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Open Questions
While we do not have IIIF or any better performing previewer... is 5 MB a sensible limit? before it was set to 500KB, which was making it fail for mostly every file.
IMPORTANT NOTE: Remember to merge this commit also to v5 branch for it to be included in the release.