Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allocation Tests fail in julia 1.4 #115

Open
mzgubic opened this issue Jul 17, 2020 · 1 comment
Open

Allocation Tests fail in julia 1.4 #115

mzgubic opened this issue Jul 17, 2020 · 1 comment
Labels
help wanted Extra attention is needed

Comments

@mzgubic
Copy link
Collaborator

mzgubic commented Jul 17, 2020

The following two tests fail in Julia 1.4:

@test 0 == @allocated NamedDimsArray(cnda, (:x, :y))
if VERSION >= v"1.1"
@test 0 == @allocated NamedDimsArray(cnda, (:x, :_))

@mzgubic mzgubic added the help wanted Extra attention is needed label Jul 17, 2020
@oxinabox oxinabox changed the title Tests fail in julia 1.4 Allocation tests fail in julia 1.4 Jul 17, 2020
@nickrobinson251 nickrobinson251 changed the title Allocation tests fail in julia 1.4 Allocation Tests fail in julia 1.4 Jul 17, 2020
@oxinabox
Copy link
Member

I think we actually do need to use @ballocated here.
And with that change sometimes i can get it down to 0 in REPL and sometimes I can't
and for some reason in the tests i can't get it below 16.

Something to playwith is disabling the compiletime_return_hack which isn't require in 1.3+ IIRC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants