Codecov Report

Merging #13 into master will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master      #13   +/-   ##
=======================================
  Coverage   93.15%   93.15%           
=======================================
  Files           3        3           
  Lines          73       73           
=======================================
  Hits           68       68           
  Misses          5        5           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5506930...bb5ffa9. Read the comment docs.

I am just not sure.
This change is definately breaking.

Packages exporting the Models.jl interface but using the StatsBase "interface" internally will become more complex as they will use both fit functions often.

Apart from fitting to some RegressionModel types - there is no particular overlap that I can see that warrants overload StatsBase.fit, StatsBase.predict. Unless RegressionModel subtypes Model in the future there shouldn't be any clashes as of now I don't think?

There are loads of clashes, with Lasso for example.
But maybe those are not to bad.

I think my gripe is that StatBase has a bunch of API stuff (like the names fit and predict) but also a ton of functionality (it's "*Base" name is a misnomer). So alternative is to move fit, predict somewhere else... but that's a whole other kettle of fish 🐟