Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace StatsBase with our own Models.fit and Models.predict #1

Open
nickrobinson251 opened this issue Mar 23, 2020 · 2 comments
Open
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@nickrobinson251
Copy link
Contributor

StatsBase is a large and unnecessaary dependency. Users should not need to depend on anything but this package itself. I propose we just define our own fit and predict, which is extended by packages implementing the interface.

@nickrobinson251 nickrobinson251 added the enhancement New feature or request label Mar 23, 2020
@nickrobinson251
Copy link
Contributor Author

nickrobinson251 commented Mar 23, 2020

looks like we'd still use StatsBase.uweights 😞

I really wish StatsBase wasn't such a rag bag of random stats functionality

I think it still makes sense for this package to own its own interface, and so have its own fit and predict, but we won't get the advantage of dropping StatsBase unless we also remove uweights from TestUtils

@nickrobinson251 nickrobinson251 added the good first issue Good for newcomers label Mar 23, 2020
@nickrobinson251
Copy link
Contributor Author

Alternatively, we could extend the fit and predict functions from much lighter-weight StatsAPI.jl
https://github.com/JuliaStats/StatsAPI.jl

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant