Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Interval Min/Max function #12

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

Arvind-Maan
Copy link

Removes the internal _firstdate and _lastdate functions and uses the Interval minimum and maximum functions.

closes #2

@codecov
Copy link

codecov bot commented Dec 30, 2020

Codecov Report

Merging #12 (9a8070b) into main (f263f49) will decrease coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #12      +/-   ##
==========================================
- Coverage   91.42%   91.37%   -0.05%     
==========================================
  Files           5        5              
  Lines          70       58      -12     
==========================================
- Hits           64       53      -11     
+ Misses          6        5       -1     
Impacted Files Coverage Δ
src/common.jl 86.36% <100.00%> (-0.31%) ⬇️
src/RandomSelector.jl 88.88% <0.00%> (-1.12%) ⬇️
src/PeriodicSelector.jl 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f263f49...9a8070b. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remove _firstdate and replace with minimum(::AbstractInterval) and similar for _lastdate
1 participant