Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API Calls, from a repo in a Github Enterprise, goes to Public Github #15

Open
marcellodesales opened this issue Jul 30, 2018 · 1 comment

Comments

@marcellodesales
Copy link
Member

Enhancement

  • Using a github enterprise repo makes calls to go to github public api
    • Users must specify the github enterprise API URL to work
    • This could be computed using the original URL
@marcellodesales
Copy link
Member Author

marcellodesales commented Aug 2, 2018

Github Enterprise Use

  • Users need to change both the docker-compose.yaml and the app/confi.js
diff --git a/app/conf.js b/app/conf.js
index d970810..9f9a713 100644
--- a/app/conf.js
+++ b/app/conf.js
@@ -1,7 +1,7 @@
 const packageJson = require("../package.json");

-export const GIT_REPOS_API = 'https://api.github.com/repos'
-export const GIT_REPOS_API_TOKEN = null;
+export const GIT_REPOS_API = 'https://github.company.com/api/v3/repos'
+export const GIT_REPOS_API_TOKEN = '4b0b6*******e1b4d6a';

 /**
  * Current Credentials
diff --git a/docker-compose.yml b/docker-compose.yml
index bea9f41..d7bc0d6 100644
--- a/docker-compose.yml
+++ b/docker-compose.yml
@@ -26,7 +26,8 @@ services:
   config-server:
     image: hyness/spring-cloud-config-server
     environment:
-      SPRING_CLOUD_CONFIG_SERVER_GIT_URI: "${SPRING_CLOUD_CONFIG_SERVER_GIT_URI:-https://github.com/marcellodesales/config-repo}"
+      SPRING_CLOUD_CONFIG_SERVER_GIT_URI: https://github.company.com/services-config/config-service-config
+      SPRING_CLOUD_CONFIG_SERVER_GIT_USERNAME: 4b0b69***********1b4d6a
       SPRING_CLOUD_CONFIG_SERVER_GIT_PASSWORD: ""
       SPRING_CLOUD_CONFIG_SERVER_GIT_CLONE_ON_START: "true"
     ports:

Rebuilding

docker-compose stop && docker-compose rm -y && docker-compose build && docker-compose up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant