-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Master build will attempt to publish the previous version. #988
Comments
Without reading into this too much I think this is the problem. If you're using lerna it will try to publish with lerna instaed of npm. Looking into this more now though |
Can you link me to that build? |
I'm not using Lerna but yarn workspaces and preconstruct. |
I'm getting a PR together that should set this up correctly. Currently with the In the future this may not be the case with #917. But that could be a ways off because I want to keep |
Thanks, I appreciate your above and beyond assistance! |
Damn that didn't work. Seems to be a git issue now though. We had docs to checkout master but i though that wasn't needed anymore. |
Seems like you might need to checkout a branch before running |
Interesting, I'll do some reading but won't that break the canary release? |
I would only do that on master. All other types of releases do not require the ability to commit. |
deploy:
- provider: script
script: if [ "$NPM_TOKEN" != "false" ];then
if [ "$TRAVIS_BRANCH" == "master" ];then
git checkout master;
fi;
yarn release;
fi;
skip-cleanup: true
on:
all_branches: true |
I'm contemplating whether the npm+lerna plugin should just do this itself EDIT: I dont think I want to. since do this automatically might break some other behavior and this is very dependent on build platform. I'm just gonna add some docs around it |
Sorry if this is getting a bit out of scope but it looks like the change also broke the PR build. Any chance it's not generating npmrc properly? |
I think I wrote the yml incorrectly |
We can update this PR with your findings: https://github.com/intuit/auto/pull/990/files |
Looks like the final change got it to work Thanks so much for the help! |
Describe the bug
npm version never increments between master builds.
After a successful publish to npm, if I merge a new PR that doesn't manually bump the version in package.json the shipit command will attempt to publish the previous version again which fails with -
To Reproduce
Got an npm package that is published independently inside a monorepo.
package.json has a version set to 1.1 for example which is already published.
I issue a new PR and when I merge it shipit attempts to publish 1.1 again.
(*) When a new tag is generated, using the TravisCI documentation you provided, it will release a canary version of the package.
Expected behavior
I'd expect shipit to publish 1.1.1 and/or update the package.json version.
Environment information:
Additional context
The project is empty and public so auto, travis.yml and the travis build are all visible.
I'm sure it's something wrong that I'm doing but I'd appreciate any pointer.
Please note that while the project is a monorepo, I'm using auto on a single package.
The text was updated successfully, but these errors were encountered: