-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
npm plugin does not bump the version in package.json #1600
Comments
This is by design. If the version is committed then it can lead to merge conflicts when merging into master. There is a git tag that's created though |
This issue is affecting me as well.
What is the recommended approach to ensure |
I'm not sure I quite understand the use case @smithki. @thuringia's use case makes sense, he needs the version to update other things, but I'm pretty hesitant to change the behavior. Can you detail what you're trying to accomplish? |
Sorry, I may have a misunderstanding. From the issue's wording, I surmise that I need to be read the |
Could you just do what |
I'll see if I can workaround it, not my intention to derail the original topic of this issue.
Unfortunately not, because the code is intended to be run client-side (I'll open a new issue if I don't find a workaround). |
Ah, another vote for me fixing dry-run behavior sooner rather than later. Will take a look at fixing all of that next weekend. Thanks for the feedback and using |
@hipstersmoothie Thanks for the quick response :) You always surprise me I found pretty solid workaround for now, In any case, thank you so much for |
@thuringia @smithki Could you test and see if v10 solves your issues? |
@hipstersmoothie This works fine in v10 👍 Thanks for getting this out so quick! Not sure if that's a bug or not: |
I'll see if I can improve that. but since we're calling to the plugin now it doing a lot more work to print the real next versions.
Ah this is a bug. for the dry run I skipped the clean check but didn't skip the git reset |
@thuringia What type of project are you releasing? |
@hipstersmoothie I'm completely fine with the dry runs being slower now. It's not that big of a difference. I mostly meant it as a remark that you feel a change, maybe I should have added an emoji there 😄 In this case it's a mixed project consisting mostly of a Java application with some lambdas around it. To create a release I have to:
Not really a default use case for |
🚀 Issue was released in |
Describe the bug
The
package.json
is not updated, when running(yarn/npx) auto shipit
on a pre-release branch.(yarn/npx) auto shipit --dry-run --quiet
is not reporting the correct version number in that case.This causes issues downstream as the version number is used to tag docker images and other artifacts.
To Reproduce
next
auto shipit
runs in Github Actionauto
released correctly to githubExpected behavior
Either package.json updates, or
auto shipit --dry-run
calculates based on tags for prereleases.Environment information:
"Current version" is wrong here already, the current tag is v0.2.0-next.11
Additional context
This might be related to #1490 ?
This appears to be by design:
auto/plugins/npm/src/index.ts
Line 869 in 2f03089
The bump is only run for base branches here, but there is no config flag to change this.
The text was updated successfully, but these errors were encountered: