Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Potential v10 Breaking Changes #1156

Closed
hipstersmoothie opened this issue Apr 17, 2020 · 1 comment
Closed

Potential v10 Breaking Changes #1156

hipstersmoothie opened this issue Apr 17, 2020 · 1 comment
Labels
major Increment the major version when merged released This issue/pull request has been released.

Comments

@hipstersmoothie
Copy link
Collaborator

hipstersmoothie commented Apr 17, 2020 •
edited

This is a tracking issue for things that could change in v10:

  • Call canary/next hooks even for dry-runs, plugins handle it, enables better --dry-run and --quiet output. bad code
  • rename afterAddToChangelog to afterChangelog since a changelog might not be committed
  • make renderChangelogLine waterfall not have to return tuple, it can just return the line
  • context in hooks - all hooks second arg should just be a context object so adding/breaking things isn't too much of a problem
  • git reset after canary and next hooks. These should not leave any traces of the last published version other than tags for next
@hipstersmoothie hipstersmoothie added the major Increment the major version when merged label Apr 17, 2020
@hipstersmoothie hipstersmoothie pinned this issue Apr 17, 2020
This was referenced May 26, 2020
Closed
Closed
@hipstersmoothie hipstersmoothie mentioned this issue Jul 12, 2020
Merged
2 tasks
@hipstersmoothie hipstersmoothie mentioned this issue Aug 7, 2020
Closed
@hipstersmoothie hipstersmoothie mentioned this issue Oct 26, 2020
Merged
6 tasks
@adierkens adierkens added the prerelease This change is available in a prerelease. label Oct 27, 2020
@adierkens
Copy link
Collaborator

🚀 Issue was released in v10.0.0 🚀

@adierkens adierkens added released This issue/pull request has been released. and removed prerelease This change is available in a prerelease. labels Oct 29, 2020
@hipstersmoothie hipstersmoothie unpinned this issue Oct 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
major Increment the major version when merged released This issue/pull request has been released.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hipstersmoothie @adierkens