Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for iOS 14 #132

Open
agroGandhi opened this issue Sep 9, 2020 · 4 comments
Open

Support for iOS 14 #132

agroGandhi opened this issue Sep 9, 2020 · 4 comments

Comments

@agroGandhi
Copy link

agroGandhi commented Sep 9, 2020

There has been some changes to Location - the main one being the changes to geolocation and the ability for the user to change the precision from within the permissions dialogue.

I can't see any branches / beta releases with any updates for this and wanted to find out if this is on your radar and what implications these changes have for the library?

Currently when I select Precise:Off and geolocate with .block accuracy I get a timeOut status response rather than a more appropriate error.

Screenshot 2020-09-09 at 14 43 14

Linking docs for accuracyAuthorization

@agroGandhi agroGandhi changed the title Update for iOS 14 / Xcode 12 Support for iOS 14 Sep 9, 2020
@agroGandhi
Copy link
Author

agroGandhi commented Sep 9, 2020

I have been looking into this further and can see why timeOut is always returned and it seems this is what currently happens when the desired INTULocationAccuracy is not returned. It seems as though the condition at line 642 in INTULocationManager.m is not met - currentLocationHorizontalAccuracy <= horizontalAccuracyThreshold. Rather than returning an appropriate accuracy status the app hangs until the timeout is reached. With the new changes to location accuracy in mind, I would like to suggest that we should add a new INTULocationStatus that indicates that accuracy has not been met as opposed to waiting for a timeout

@lwdupont
Copy link
Contributor

lwdupont commented Sep 9, 2020

Hmm.. Ya, good call out. I got a job at Apple now, so I'm not supposed to help on open source projects without permission from legal. And truthfully I don't have time even if I was allowed.

@croossin do you have time or interest? @roxiomontes anyone interested in looking at this?

@jjksam
Copy link

jjksam commented Sep 20, 2020

Hi, I've created a pull request to allow simple process for users who using this framework. Please check if it's possible to merge.

@maulikshah09
Copy link

@jjksam any fix for this or new branh.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants