Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move XPIs to release section #116

Open
KOLANICH opened this issue Feb 9, 2019 · 4 comments
Open

Move XPIs to release section #116

KOLANICH opened this issue Feb 9, 2019 · 4 comments
Labels
to-do (approved) Next release to-do

Comments

@KOLANICH
Copy link

KOLANICH commented Feb 9, 2019

1 You will need to rewrite history (there is an app for that), otherwise the wasted space won't be reclaimed.
2 It is not a good idea to store xpis in the repo at all.

@intika
Copy link
Owner

intika commented Feb 9, 2019

I will move them to release section later on ;)
They will be moved from there anyway

@intika intika changed the title It is incorrect to store binary files right in repo. Use Git LFS for that. Move XPIs to release section Feb 9, 2019
@intika intika added the to-do (approved) Next release to-do label Feb 9, 2019
@KOLANICH
Copy link
Author

KOLANICH commented Feb 9, 2019

IMHO XPIs should be installed from the files provided by their authors, not the ones stored separately. Extensions are separate products, let's not mix them with the browser. They can be installed by default, but they should be installed not from bundled xpis, but from the ones supplied by their authors. In other words, when a browser creates a new profile, it should ask its user if a user needs the default adddons to be installed, and if the user approves, then the browser should download and install them. Or it may show not a confirm, but a window with checkboxes, one for an addon, all selected by default, and for each addon a description why it was decided to add it into the recommended bundle.

@intika
Copy link
Owner

intika commented Feb 9, 2019

Those xpi versions are reviewed, it's why i made a copy there (a reviewed version, code check/review) newer version may add unwanted behavior... but yes this should even be on a different repo/release-section with a similar solution to the one you exposed ;)

@KOLANICH
Copy link
Author

KOLANICH commented Feb 9, 2019

Those xpi versions are reviewed

It is good they are reviewed, but you can store only their locations and hashes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
to-do (approved) Next release to-do
Projects
None yet
Development

No branches or pull requests

2 participants