Change Matomo script, remove visible HTML

[bwbroersma]

Currently this custom code is added in the HTML:

  <div class="hidethis" aria-hidden="true">
    <span id="matomo-url">//matomo.internet.nl/</span>
    <span id="matomo-siteid">1</span>
    <span id="matomo-subdomain-tracking">*.internet.nl</span>
  </div>

It uses the hidethis class to hide it and then uses frontend/js/matomo.js to pass this on as arguments for the Matomo javascript.

This is obviously done to comply with CSP & keep it dynamic configurable. Although another approach would be to generate the JS with the parameters. An improvement to the current code would be to use HTML 5 hidden attribute instead of CSS rule:

Internet.nl/frontend/css/style.css

Lines 961 to 963 in db713eb

	.hidethis {
	display:none !important; /* bad but we need to make sure that something will be hidden */
	}

The current variables are only in the settings.py and base template:

Internet.nl/internetnl/settings.py

Lines 109 to 114 in fca192a

	# Features
	# # User Tracking
	MATOMO_URL = getenv("MATOMO_URL", "//matomo.internet.nl/")
	MATOMO_SITEID = int(getenv("MATOMO_SITEID", "1"))
	# # Used for subdomain tracking eg. *.internet.nl
	MATOMO_SUBDOMAIN_TRACKING = getenv("MATOMO_SUBDOMAIN_TRACKING", "")

Internet.nl/interface/templates/base.html

Lines 30 to 34 in fca192a

	<div class="hidethis" aria-hidden="true">
	<span id="matomo-url">{{"MATOMO_URL"|get_settings_value}}</span>
	<span id="matomo-siteid">{{"MATOMO_SITEID"|get_settings_value}}</span>
	<span id="matomo-subdomain-tracking">{{"MATOMO_SUBDOMAIN_TRACKING"|get_settings_value}}</span>
	</div>

via docker compose env of the app container:

Internet.nl/docker/docker-compose.yml

Lines 151 to 153 in fca192a

	- MATOMO_URL
	- MATOMO_SITEID
	- MATOMO_SUBDOMAIN_TRACKING

Currently the app (Django) container is serving the /static files, so either fix it during minimizing:

Internet.nl/docker/Dockerfile

Line 204 in fca192a

RUN python3 bin/frontend.py js

or, since the Django code doesn't uses these variables, it could be done with a .template and adding a line like this below the line mentioned above:

RUN envsubst < ...matamo.js.template > ...matamo.js