Need some further help with forked site customization

[apio-sys]

I have the language part working as per the updated documentation/Customize.md a part from a small issue with the integration-test as posted separately here #1338 .

I still have quite a few questions to continue the customization of a fork of the project. You mentioned that others are currently working on custom sites. Maybe we can all share any findings and tips & tricks. I'll do my best to help update documentation where I can.

For the language part cont'd:

• integration-test fail on language-switcher, see Build fails on integration-test after a new language has been added #1338 .
• the placeholders on the test form fields are not localized (i.e. www.example.nl). It would make sense I think to have this originating from the translation files so when localize the placeholder as i.e. www.mondomaine.fr. I noticed the placeholder seems hardcoded here: interface/templates/widget-site.html:

<input id="internetnl-site-url" type="url" name="url" placeholder="www.domaine.fr">

that change is not picked-up on the front after rebuilding. I'm not sure how to integrate such changes (and if it's wise to do so since touching core files...).

• I'm not very clear on how to use the news.po file and have it show on the home page. Could you please point me in the right direction?

Styling:

• as per documentation/Customize.md I managed to change some basic color settings through frontend/css/style.css . Am I correct in assuming that any further and more impacting changes should go here: interface/templates?

security.txt:

• I notice the file returns a 404 because of this in the Nginx config:

    # disable security.txt if branding is disabled
    set $internetnl_branding "False";
    location = /.well-known/security.txt {
      if ($internetnl_branding != "True"){
        return 404;
      }
      # basic auth should not apply to this path
      auth_basic off;
      # IP allowlist should also not apply
      allow all;
      alias /var/www/internet.nl/.well-known/security.txt;
    }

Should this just be harcoded to the wanted value (and updated content in security.txt)?

[bwbroersma]

Thanks for the valid questions.

About example.nl, that should indeed be a variable, I'm a bit unsure if it should be a in the translation or an environment variable.

The security.txt setup will probably change a bit, related:

• Add CSP and correct security.txt to dev-docker #1227 (comment)

Related:

• Docker followup #1042
• Extend branding options for new Docker image #1188

[apio-sys]

Thanks for the reply @bwbroersma and the reference to the discussion in #1188 . Even though it is still a discussion, I would appreciate some indications to start and get the ball rolling. I.e. get the news page working (this doesn't seem to pickup from the translated version in the fork) and add an about page. Should I go for direct modifications inside the /interface/templates folder or will this pose an issue keeping the fork in sync if things change upstream? Just looking for the cleanest method while keeping the fork in sync all the time. Sometimes this poses problem i.e. with the certbot.sh script since subdomain names for languagues are hardcoded, but that is manageable by cherrypicking during merges. But it shouldn't be a cause to get of the rails completely and ending up with a fork that doesn't have it's core up2date.

[mxsasha]

We don't have a specific recommendation for how to modify the templates I think. Currently we barely change them at all. We are working towards a redesign which will change many templates, but that's pretty long term. Underway is rewriting the TLS code, but I don't think you'll change that much.