Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit TTL #1340

Open
bwbroersma opened this issue Mar 18, 2024 · 1 comment · Fixed by #1292
Open

Limit TTL #1340

bwbroersma opened this issue Mar 18, 2024 · 1 comment · Fixed by #1292

Comments

@bwbroersma
Copy link
Collaborator

@janwillemstegink had an idea to limit the TTL, I said this was already done:

cache-max-ttl: 60
cache-max-negative-ttl: 60

But these are not yet deployed in v1.8.5, I tested a domain with a TTL record of a week, and it's indeed still cached.
Fixed with 47fa821 from merge:

Close this issue if it's deployed?

@bwbroersma
Copy link
Collaborator Author

@mxsasha: I see the TTL is both set as context and in a config file? The code settings seems redundant to the unbound conf?

self._ub_ctx.set_option("cache-max-ttl:", str(settings.CACHE_TTL * 0.9))
self._ub_ctx.set_option("cache-max-negative-ttl:", str(settings.CACHE_TTL * 0.9))

What should I now see on v1.8.5 single-test? Since it seems higher than the max caching of 200 * 0.9:
CACHE_TTL = int(os.getenv("INTERNETNL_CACHE_TTL", 200))

BTW shouldn't this move to the unbound conf too?

self._ub_ctx.set_option("rrset-roundrobin:", "no")

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

1 participant