Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2021 Q3/4 Internationalization: Making OpenLibrary Multilingual #791

Closed
12 of 16 tasks
justcomplaining opened this issue Feb 7, 2018 · 26 comments
Closed
12 of 16 tasks
Assignees
Labels
Affects: UI Issues with the web site's user interface. [managed] Lead: @cdrini Issues overseen by Drini (Staff: Team Lead & Solr, Library Explorer, i18n) [managed] Priority: 2 Important, as time permits. [managed] Theme: Internationalization Making OpenLibrary work for both foreign-language users and books. [managed] Type: Epic A feature or refactor that is big enough to require subissues. [managed] Type: Feature Request Issue describes a feature or enhancement we'd like to implement. [managed]
Milestone

Comments

@justcomplaining
Copy link
Collaborator

justcomplaining commented Feb 7, 2018

From @justcomplaining: It seems like the potential of the project for international users is greatly limited by the missing front end translation. I would gladly volunteer to help with German, if needed.


(below this point edited by @mekarpeles)

Goal

From @brad2014 in #2190:

This is an epic that covers sub-issues related to both

  • moving the server onto a translation maintenance pipeline (Weblate? Pootle? Zanata?)
  • refactoring the user interface so that foreign language users see the UI in their language
  • creating and maintaining UI translations

The UI will be polylingual, presenting label elements in the user language and content elements in the content language. (With exceptions: e.g. if a data field of a work is its ISO-639 language, that datum would be presented in the user's language. FR would be presented as French or Français or Französich, etc).

How to Contribute

Adding a new language: https://github.com/internetarchive/openlibrary/tree/master/openlibrary/i18n#adding-a-new-language

Language coverage:

Open Issues

Related issues:

And #2417, #1146, #4042, #3907, #3834, #3834, #3811, #3725, #3723, #3557, #3511, #3354, #3351, #3034, #3173, #3171, #3169, #3067

@mekarpeles
Copy link
Member

Please! We'd love the help. We do have have i18n internationaliztion / localization files in place but I'm not sure if they are correctly being used.

See: https://openlibrary.org/i18n and https://github.com/internetarchive/openlibrary/tree/f8092840a77c7479a352fd83fd068d340f97d3e3/openlibrary/plugins/openlibrary/i18n

@LeadSongDog
Copy link

They definitely are not. There's no place to for the user to make a language choice ever since the login moved from OL to IA.

@justcomplaining
Copy link
Collaborator Author

Since the last commit to that part of the repo was 2009 I guess it doesn't make much sense to try to work with these files, right? I'll just wait until multiple languages are supported again and then I am ready to help. :)

@LeadSongDog
Copy link

@justcomplaining Please don't abandon hope, the login problem is a recent development. I'm sure it's possible to find a solution.

@mekarpeles
Copy link
Member

mekarpeles commented Feb 11, 2018

There's a lot of code that was last touched in 2009 -- the project was dormant for several years due to lack of developers.

I fully support @LeadSongDog's comment; our core team is very small and we only have so much time to push important issues forward. Internationalization is an important one, so if you have the bandwidth, I hope you'll give it a shot! We're here to help you.

@LeadSongDog LeadSongDog mentioned this issue Feb 15, 2018
1 task
@hornc
Copy link
Collaborator

hornc commented Feb 15, 2018

Thanks @LeadSongDog for the link. WIP PR #801 was prompted by this issue and other recent efforts and questions around i18n.

I'd love to get things in a state where other volunteers can proceed with translations and see them in effect on the site! I think there might be some initial work required to get the msg strings in good order, but I have at least updated and fixed a few issues with the python Babel string extraction etc, so at least the process can be run now, and the messages can be updated.

@mekarpeles mekarpeles changed the title Multilingual website Internationalization: Making OpenLibrary Multilingual Feb 20, 2018
@mekarpeles mekarpeles added Theme: Internationalization Making OpenLibrary work for both foreign-language users and books. [managed] languages labels Feb 20, 2018
@mekarpeles mekarpeles added this to @mekarpeles in 2018 Q2 Mar 13, 2018
@mekarpeles mekarpeles moved this from @mekarpeles to Prioritized in 2018 Q2 Mar 13, 2018
@tfmorris
Copy link
Contributor

@justcomplaining Now that @hornc has finished work on #801 and it has been merged, do you have what you need to work on a German translation or do you need more guidance in the form of a README or Wiki page?

@hornc
Copy link
Collaborator

hornc commented Mar 15, 2018

@LeadSongDog and others, OL currently will honour browser language settings to enable i18n, so there is a mechanism for users to choose language (I only discovered this was working recently).

Currently there is a partial Telegu translation live, and once #801 is pushed to production [**UPDATE 20 Mar 2018, it's live now] Czech, translated by @Clonewayx (thank you very much for your work which has kick-started this!) will be visible the same way. Now we need more languages, and reviews to ensure all the important messages are covered by i18n.

There are a small number of translations in other languages here for a minimal set of messages here: https://github.com/internetarchive/openlibrary/tree/master/openlibrary/plugins/openlibrary/i18n
In the deprecated strings. format

es Spanish
hi Hindi
it Italian
kn Kannada
mr Marathi

These need to be checked and moved to the new format (if the messages are still in use) and then removed from the repo, along with the associated code for the deprecated i18n method.

Issue created: #871

@sbshah97
Copy link
Contributor

I'd like to help in contributing to the Telugu part this weekend!

@justcomplaining
Copy link
Collaborator Author

@tfmorris I will take a look sometime soon and get back to you should I have any questions. :)

@sbshah97
Copy link
Contributor

I think we can close this and make #871 as the main Issue as it describes the problem rather perfectly! I propose we change the title of #871 to have it as a base Issue for Internationalization.
The wiki for internationalization can be found here

@sbshah97
Copy link
Contributor

@mekarpeles @hornc what do you think about making #871 as it is slightly more detailed regarding Internationalization

@justcomplaining
Copy link
Collaborator Author

I think there is more to this issue than migrating translation methods, e.g. frontend selection of language.

@sbshah97
Copy link
Contributor

Frontend selection language as in ?

@LeadSongDog
Copy link

@salman-bhai I think what @justcomplaining is referring to is that there is no longer a way for users to specifiy their language preference. Most other wikis have extensive preference setting options such as https://en.wikipedia.org/wiki/Special:Preferences, but not so https://openlibrary.org/account which has very little. Particularly, it has no language setting. Even worse, some of the preferences are on another site entirely (archive.org). I'm told that it is possible to change browser settings in such a way that openlibrary will operate in another language, but I've yet to see how. In any case, it should be a one or two click toggle, not an arcane "do this then that then the other thing then log out and reboot while standing on your left heel and reciting the CC-BY-NC-3.0 license backwards from memory" sort of instruction.

@nemobis
Copy link

nemobis commented Nov 7, 2018

Thanks for working on this. It would be great to enlist the help of the translatewiki.net community and software to get more translations (with translation memory and many other features):
https://translatewiki.net/wiki/Translating:New_project

@hornc
Copy link
Collaborator

hornc commented Nov 7, 2018

Thanks for the link to translatewiki @nemobis , it looks promising and just like the crowd sourced method we have been wanting to implement. I will look into what it will take to add Open Library as a project

@mekarpeles mekarpeles added this to Epic in 2021 Epics via automation Jan 21, 2021
@mekarpeles mekarpeles modified the milestones: 2018 Q2, Next (proposed) Feb 24, 2021
@mekarpeles mekarpeles added Priority: 2 Important, as time permits. [managed] and removed Priority: 3 Issues that we can consider at our leisure. [managed] labels Feb 24, 2021
@lephemere
Copy link
Contributor

lephemere commented Feb 27, 2021

Regarding internationalization, I quickly went through OL main pages and identified the ones which could greatly improve non-english speaking user experience.

@oshliaer
Copy link

@lephemere

  • Around the Library (bottom of main content of the start page)
  • Footer (it is verbose)
Details

1614488702614

@lephemere
Copy link
Contributor

@contributorpw
I've checked the templates associated to these parts and they are all i18n friendly.
We need to update the i18n message template and translate for each language.

@cdrini cdrini added Lead: @cdrini Issues overseen by Drini (Staff: Team Lead & Solr, Library Explorer, i18n) [managed] and removed Needs: Lead labels May 3, 2021
@lephemere
Copy link
Contributor

Some thoughts on i18n:

  • Could be interesting to have an overview of translation coverage for each available language (translated_msgstr/all_msgstr)
  • Do we have some stats on page default display language from OL users web browser?

@mekarpeles mekarpeles added this to In progress in Internationalization (i18n) Jun 5, 2021
@mekarpeles mekarpeles moved this from In progress to To do in Internationalization (i18n) Jun 5, 2021
@mekarpeles mekarpeles changed the title 2021 Q2 Internationalization: Making OpenLibrary Multilingual 2021 Q3/4 Internationalization: Making OpenLibrary Multilingual Aug 2, 2021
@cdrini
Copy link
Collaborator

cdrini commented Oct 4, 2021

This overlaps with #5134 😬 Need to untangle at some point.

@cdrini
Copy link
Collaborator

cdrini commented Feb 17, 2023

Closing as the milestone has passed. The sub-tasks are independent enough and can stand on their own.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Affects: UI Issues with the web site's user interface. [managed] Lead: @cdrini Issues overseen by Drini (Staff: Team Lead & Solr, Library Explorer, i18n) [managed] Priority: 2 Important, as time permits. [managed] Theme: Internationalization Making OpenLibrary work for both foreign-language users and books. [managed] Type: Epic A feature or refactor that is big enough to require subissues. [managed] Type: Feature Request Issue describes a feature or enhancement we'd like to implement. [managed]
Projects
2018 Q2
  
Q2 Todos (Prioritized)
Triage
  
Triaged
Development

No branches or pull requests