Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ISBN star queries no longer work #2623

Closed
cdrini opened this issue Nov 12, 2019 · 6 comments
Closed

ISBN star queries no longer work #2623

cdrini opened this issue Nov 12, 2019 · 6 comments
Labels
Affects: UI Issues with the web site's user interface. [managed] Priority: 3 Issues that we can consider at our leisure. [managed] Theme: Identifiers Issues related to ISBN's or other identifiers in metadata. [managed] Theme: Search Issues related to search UI and backend. [managed] Type: Bug Something isn't working. [managed]
Projects
Triage

Comments

@cdrini
Copy link
Collaborator

cdrini commented Nov 12, 2019

Evidence / Screenshot (if possible)

Relevant url?

https://openlibrary.org/search?q=isbn%3A02620%2A&mode=everything

Expectation

It should give results

Details

  • Logged in (Y/N)? Y
  • Browser type/version? FF69
  • Operating system? Win10

Proposal & Constraints

Stakeholders

@LeadSongDog @tfmorris
@cdrini cdrini added the Type: Bug Something isn't working. [managed] label Nov 12, 2019
@cdrini cdrini mentioned this issue Nov 12, 2019
Open
@hornc
Copy link
Collaborator

hornc commented Nov 12, 2019

@cdrini I had no idea this ever was a feature ;)

@cdrini
Copy link
Collaborator Author

cdrini commented Nov 12, 2019

Haha, me neither actually; but now I want to use it :P Found the link on #372

@hornc
Copy link
Collaborator

hornc commented Nov 12, 2019

@cdrini actually, I think some of the recent ISBN processing standardisation may be catching the isbn query strings and sanitising them , as discussed in #609

I wasn't aware the passing isbn:978* to Solr was a feature, so it hasn't be catered for in the ISBN standardising.

@hornc hornc mentioned this issue Nov 12, 2019
Closed
@hornc hornc added Theme: Search Issues related to search UI and backend. [managed] Theme: Identifiers Issues related to ISBN's or other identifiers in metadata. [managed] labels Nov 12, 2019
@cdrini cdrini changed the title isbn star queries no longer work ISBN star queries no longer work Nov 12, 2019
@xayhewalo xayhewalo added this to Un-Triaged in Triage Nov 15, 2019
@xayhewalo xayhewalo added Affects: UI Issues with the web site's user interface. [managed] Needs: Triage This issue needs triage. The team needs to decide who should own it, what to do, by when. [managed] Priority: 3 Issues that we can consider at our leisure. [managed] labels Nov 26, 2019
@xayhewalo xayhewalo moved this from Un-Triaged to Needs: Assessment in Triage Nov 26, 2019
@LeadSongDog
Copy link

With standardizing, what form is the ISBN being stored in? A string of 13 digits without hyphens?

@mekarpeles mekarpeles removed the Needs: Triage This issue needs triage. The team needs to decide who should own it, what to do, by when. [managed] label Apr 20, 2020
@cdrini
Copy link
Collaborator Author

cdrini commented Feb 7, 2022

This appears to work now! Note isbn:978* fails as a result of search sometimes erroring if there are tooo many results (there's an issue I can't find...)

@cdrini cdrini closed this as completed Feb 7, 2022
@LeadSongDog
Copy link

LeadSongDog commented Feb 7, 2022 •
edited

Well, it sort of works now, but these queries should get the same results (and don’t):
https://openlibrary.org/search?q=isbn%3A978-02*&mode=everything
https://openlibrary.org/search?q=isbn%3A97802*&mode=everything
https://openlibrary.org/search?q=isbn%3A02*&mode=everything

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Affects: UI Issues with the web site's user interface. [managed] Priority: 3 Issues that we can consider at our leisure. [managed] Theme: Identifiers Issues related to ISBN's or other identifiers in metadata. [managed] Theme: Search Issues related to search UI and backend. [managed] Type: Bug Something isn't working. [managed]
Projects
No open projects
Triage
  
Needs: Assessment
Milestone
No milestone
Development

No branches or pull requests
5 participants
@hornc @mekarpeles @cdrini @xayhewalo @LeadSongDog