Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Works w/ Missing Covers Should Fallback to Available Edition Cover #2447

Closed
BrittanyBunk opened this issue Oct 2, 2019 · 5 comments
Closed

Works w/ Missing Covers Should Fallback to Available Edition Cover #2447

BrittanyBunk opened this issue Oct 2, 2019 · 5 comments
Assignees
@mekarpeles
Labels
Affects: Librarians Issues related to features that librarians particularly need. [managed] Lead: @mekarpeles Issues overseen by Mek (Staff: Program Lead) [managed] Module: Books Page Module: Cover Service Cover Store (book covers service) Priority: 2 Important, as time permits. [managed] Type: Feature Request Issue describes a feature or enhancement we'd like to implement. [managed]
Projects
Triage

Comments

@BrittanyBunk
Copy link
Contributor

When looking through the books on the main page, many of them have no cover. However, one edition is likely to have a cover. So I need to go through each and every book to add the cover that's on one edition to the book's home page. It would be nice to have a cover automatically posted to the book's main page the second a cover on even one of the editions is posted.
@BrittanyBunk BrittanyBunk added the Type: Feature Request Issue describes a feature or enhancement we'd like to implement. [managed] label Oct 2, 2019
@xayhewalo xayhewalo added this to Un-Triaged in Triage Oct 20, 2019
@BrittanyBunk BrittanyBunk mentioned this issue Oct 27, 2019
Closed
@mekarpeles mekarpeles added the Module: Cover Service Cover Store (book covers service) label Oct 29, 2019
@xayhewalo xayhewalo added Affects: Librarians Issues related to features that librarians particularly need. [managed] Needs: Triage This issue needs triage. The team needs to decide who should own it, what to do, by when. [managed] Priority: 3 Issues that we can consider at our leisure. [managed] State: Backlogged Good First Issue Easy issue. Good for newcomers. [managed] labels Nov 24, 2019
@xayhewalo
Copy link
Collaborator

By "book" I assume you mean "work"? If so, I'm assuming it'd be easy to check if 1) a work has no cover 2) this coverless work has editions with a cover and 3) add the editions cover id to a work

@xayhewalo xayhewalo moved this from Un-Triaged to Needs: Assessment in Triage Nov 24, 2019
@BrittanyBunk
Copy link
Contributor Author

@guyjeangilles yes, I think that would work!

@xayhewalo xayhewalo mentioned this issue Nov 25, 2019
Closed
@mekarpeles mekarpeles changed the title Add a main cover automatically when one new cover appears Works w/ Missing Covers Should Fallback to Available Edition Cover Dec 12, 2019
@mekarpeles mekarpeles removed the Good First Issue Easy issue. Good for newcomers. [managed] label Dec 12, 2019
@mekarpeles mekarpeles self-assigned this Dec 12, 2019
@mekarpeles
Copy link
Member

I'm going to assign to myself; this falls under #684

@mekarpeles mekarpeles added Module: Books Page Priority: 2 Important, as time permits. [managed] and removed Priority: 3 Issues that we can consider at our leisure. [managed] labels Dec 12, 2019
@BrittanyBunk
Copy link
Contributor Author

@mekarpeles I think you are the right person for this, as you fixed the other similar bug :)

@mekarpeles mekarpeles added the Lead: @mekarpeles Issues overseen by Mek (Staff: Program Lead) [managed] label Dec 17, 2019
@xayhewalo xayhewalo removed the Needs: Triage This issue needs triage. The team needs to decide who should own it, what to do, by when. [managed] label Dec 24, 2019
@xayhewalo xayhewalo mentioned this issue Feb 11, 2020
Closed
@xayhewalo
Copy link
Collaborator

Closing as #684 addresses this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mekarpeles mekarpeles

Labels
Affects: Librarians Issues related to features that librarians particularly need. [managed] Lead: @mekarpeles Issues overseen by Mek (Staff: Program Lead) [managed] Module: Books Page Module: Cover Service Cover Store (book covers service) Priority: 2 Important, as time permits. [managed] Type: Feature Request Issue describes a feature or enhancement we'd like to implement. [managed]
Projects
No open projects
Triage
  
Needs: Assessment
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mekarpeles @xayhewalo @BrittanyBunk