Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show the size limit for cover image uploads #2390

Closed
BrittanyBunk opened this issue Sep 14, 2019 · 13 comments
Closed

Show the size limit for cover image uploads #2390

BrittanyBunk opened this issue Sep 14, 2019 · 13 comments
Labels
Affects: UI Issues with the web site's user interface. [managed] Good First Issue Easy issue. Good for newcomers. [managed] Needs: Triage This issue needs triage. The team needs to decide who should own it, what to do, by when. [managed] Priority: 3 Issues that we can consider at our leisure. [managed] Type: Feature Request Issue describes a feature or enhancement we'd like to implement. [managed]
Projects
Triage

Comments

@BrittanyBunk
Copy link
Contributor

It's 30 MB
@BrittanyBunk BrittanyBunk added the Type: Feature Request Issue describes a feature or enhancement we'd like to implement. [managed] label Sep 14, 2019
@cdrini
Copy link
Collaborator

cdrini commented Sep 16, 2019

👍 Sounds good to me; @mekarpeles is the max 30mb? Where is that defined?

@xayhewalo xayhewalo added this to Un-Triaged in Triage Oct 20, 2019
@xayhewalo xayhewalo added Affects: UI Issues with the web site's user interface. [managed] Good First Issue Easy issue. Good for newcomers. [managed] Priority: 3 Issues that we can consider at our leisure. [managed] State: Backlogged Needs: Triage This issue needs triage. The team needs to decide who should own it, what to do, by when. [managed] labels Nov 22, 2019
@xayhewalo xayhewalo moved this from Un-Triaged to Needs: Assessment in Triage Nov 22, 2019
@xayhewalo
Copy link
Collaborator

Signal boost @mekarpeles

@BrittanyBunk
Copy link
Contributor Author

@seabelis since you know how to edit the FAQs, what do you think about adding it there?

@Aj-KamaL Aj-KamaL mentioned this issue Mar 18, 2020
Open
@devarshigoswami
Copy link
Contributor

Can I take this up?

@BrittanyBunk
Copy link
Contributor Author

I'm not working on this any further, so whoever wants to is fine by me.

@devarshigoswami
Copy link
Contributor

@BrittanyBunk @mekarpeles what I can do is add a small script right inside templates/covers/add.html that validates the size of the locally selected file that will alert if filesize exceeds 30mb.
But the upload image using URL from the web confuses me a little. no matter what image URL i post, this comes up

**Sorry. There seems to be a problem with what you were just looking at.

We've noted the error 2020-04-01/172635766108 and will look into it as soon as possible. Head for home?**

@BrittanyBunk
Copy link
Contributor Author

@devarshigoswami that sounds like a different issue.

For this issue:

  1. an alert is a good idea, but is complementary to the starting point
  2. The starting point is putting in the instructions about how images over 30MB won't upload. The alert will complement that.

I'm not sure you'll be able to edit the instructions, so I really like your idea. @seabelis since you wrote in the instructions last, would that be a possibility to add in?

@devarshigoswami
Copy link
Contributor

@BrittanyBunk Is the FAQ page maintained somewhere outside the sourcecode repo? because It's not showing if I open a local instance of Openlibrary on my PC using docker.

@seabelis
Copy link
Collaborator

seabelis commented Apr 2, 2020

@devarshigoswami FAQ page is https://openlibrary.org/help/faq/editing#picture. It's been updated with the size limit.

@devarshigoswami
Copy link
Contributor

Awesome! @seabelis can I open a new issue for validation of that 30mb limit via a script?

@tfmorris
Copy link
Contributor

tfmorris commented Apr 2, 2020

@devarshigoswami There is already #3208 (and associated PR)

@BrittanyBunk
Copy link
Contributor Author

Awesome. Thanks everyone for helping out with this. I'll close it now!

Triage automation moved this from Needs: Assessment to Closed Apr 3, 2020
@BrittanyBunk
Copy link
Contributor Author

@devarshigoswami I agree, #3208 is where you'd place your proposal I believe.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Affects: UI Issues with the web site's user interface. [managed] Good First Issue Easy issue. Good for newcomers. [managed] Needs: Triage This issue needs triage. The team needs to decide who should own it, what to do, by when. [managed] Priority: 3 Issues that we can consider at our leisure. [managed] Type: Feature Request Issue describes a feature or enhancement we'd like to implement. [managed]
Projects
No open projects
Triage
  
Closed
Milestone
No milestone
Development

No branches or pull requests
6 participants
@tfmorris @cdrini @xayhewalo @seabelis @devarshigoswami @BrittanyBunk