Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace all mentions of vagrant with docker #1134

Closed
21 tasks done
cdrini opened this issue Sep 17, 2018 · 13 comments
Closed
21 tasks done

Replace all mentions of vagrant with docker #1134

cdrini opened this issue Sep 17, 2018 · 13 comments
Assignees
@tfmorris
Labels
Affects: Documentation Issues related to developer or ops or data documentation. [managed] Module: Docker Issues related to the configuration or use of Docker. [managed] Priority: 3 Issues that we can consider at our leisure. [managed] Theme: Provisioning Type: Refactor/Clean-up Issues related to reorganization/clean-up of data or code (e.g. for maintainability). [managed]
Projects
Triage

Comments

@cdrini
Copy link
Collaborator

cdrini commented Sep 17, 2018 •
edited by mekarpeles

Make docker the one and only development option. There should be (virtually) no trace of vagrant left.

< Following added by @jdlrobson >
Files that reference Vagrant:

Wiki pages that reference Vagrant:
@cdrini cdrini mentioned this issue Sep 17, 2018
Closed
2 tasks
@tabshaikh
Copy link
Collaborator

@cdrini you sounded like a vagrant killer there 😂

@mekarpeles mekarpeles added Theme: Provisioning vagrant Module: Docker Issues related to the configuration or use of Docker. [managed] labels Sep 17, 2018
mekarpeles added a commit that referenced this issue Oct 6, 2018
@mekarpeles
updating main readme to include docker setup docs
698562a 
Towards #1134
@mekarpeles mekarpeles mentioned this issue Oct 6, 2018
Merged
@jdlrobson
Copy link
Collaborator

This looks resolved to me!

@cdrini
Copy link
Collaborator Author

cdrini commented Dec 22, 2018

There are still references: https://github.com/internetarchive/openlibrary/search?q=vagrant&unscoped_q=vagrant

A lot of those files can be deleted entirely, because they're not used at all by our new docker flow.

@cdrini cdrini reopened this Dec 22, 2018
@jdlrobson
Copy link
Collaborator

@cdrini I've listed all the files above. Don't know enough about the config to know which can be deleted, but openlibrary/plugins/upstream/account.py is a doc change and the lines in gitignore and dockerignore can be removed.

@cdrini
Copy link
Collaborator Author

cdrini commented Jan 2, 2019

Thanks @jdlrobson ! I converted it to a checklist; we can target chunks of these at a time, and close the ticket once they're all done.

This was referenced Jan 3, 2019
Merged
Merged
Merged
Merged
@tfmorris
Copy link
Contributor

tfmorris commented Feb 19, 2019 •
edited

I think we need to add some wiki pages to the work list here: https://github.com/internetarchive/openlibrary/search?q=vagrant&type=Wikis

The Testing and Getting Started ones are probably most important.

@cdrini
Copy link
Collaborator Author

cdrini commented Feb 19, 2019

👍 Added to the list.

@tfmorris
Copy link
Contributor

Thanks @cdrini ! The sidebar only referenced the switching from Vagrant topic, so I've checked it off the list.

@tfmorris
Copy link
Contributor

I've fixed the remaining wiki pages, but the Testing page seems pretty out of date with our current setup (and assumes things like access to private OL machines), so probably needs more work.

@mekarpeles
Copy link
Member

Thanks @tfmorris!

@mekarpeles mekarpeles mentioned this issue Apr 11, 2019
Closed
@cdrini
Copy link
Collaborator Author

cdrini commented Apr 11, 2019

There are still some files in the repo that need updating.

@cdrini cdrini reopened this Apr 11, 2019
@tfmorris tfmorris self-assigned this Apr 11, 2019
@tfmorris
Copy link
Contributor

@cdrini Thanks for reopening
@mekarpeles I'll close when the work is complete.

@brad2014 brad2014 added Affects: Documentation Issues related to developer or ops or data documentation. [managed] and removed vagrant labels May 4, 2019
@xayhewalo xayhewalo added this to Un-Triaged in Triage Oct 18, 2019
@xayhewalo xayhewalo added Priority: 3 Issues that we can consider at our leisure. [managed] State: Backlogged Type: Refactor/Clean-up Issues related to reorganization/clean-up of data or code (e.g. for maintainability). [managed] labels Nov 8, 2019
@xayhewalo xayhewalo moved this from Un-Triaged to Triaged in Triage Nov 8, 2019
This was referenced Dec 12, 2019
Merged
Merged
Merged
@mekarpeles
Copy link
Member

#2720 #2721 #2722

Triage automation moved this from Triaged to Closed Dec 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tfmorris tfmorris

Labels
Affects: Documentation Issues related to developer or ops or data documentation. [managed] Module: Docker Issues related to the configuration or use of Docker. [managed] Priority: 3 Issues that we can consider at our leisure. [managed] Theme: Provisioning Type: Refactor/Clean-up Issues related to reorganization/clean-up of data or code (e.g. for maintainability). [managed]
Projects
No open projects
Triage
  
Closed
Milestone
No milestone
Development

No branches or pull requests
7 participants
@tfmorris @jdlrobson @mekarpeles @cdrini @brad2014 @xayhewalo @tabshaikh