Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github pages action has the wrong URL on instances (test deployment recipies) #99

Open
4www opened this issue Jul 26, 2023 · 0 comments

Comments

@4www
Copy link
Contributor

4www commented Jul 26, 2023

In the case of the fork https://github.com/4www/find

and its deployment page https://4www.github.io/find/

the view-source:https://4www.github.io/find//assets/opensearch.xml has incorrect values, and point to the internet4000.github.io/find instance

the workflow job https://github.com/internet4000/find/blob/main/.github/workflows/static.yml#L26-L27

is called to generate the XML (for each deploy) in this script https://github.com/4www/find/blob/main/src/scripts/opensearch-xml.js#L46

and uses I4K_FIND_URL from the env vars.

It should be customized manually in github UI, by should be used with a value provided by github actions runners https://github.com/internet4000/find/blob/main/.github/workflows/static.yml#L28-L29

Not sure why it does not pick it.

  • generally, try each deployment recipe, and see Find works correctly (generating the files etc.) for each of them, without the need of any user configuration
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant