Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proper masking #37

Open
rameyer opened this issue Dec 9, 2021 · 2 comments
Open

Proper masking #37

rameyer opened this issue Dec 9, 2021 · 2 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@rameyer
Copy link
Member

rameyer commented Dec 9, 2021

See #36 : masking should create a numpy mask or self.masked_im, with all the edits to the main functions that it implies.
@lboogaard lboogaard mentioned this issue Dec 9, 2021
Merged
@rameyer rameyer added enhancement New feature or request help wanted Extra attention is needed labels Jan 3, 2022
@rameyer rameyer added bug Something isn't working and removed enhancement New feature or request labels Mar 14, 2022
@lboogaard
Copy link
Collaborator

I agree this would be nice to have (but some work to implement).
The current masking does work fine (there are no bugs?)

@lboogaard lboogaard added enhancement New feature or request and removed bug Something isn't working labels Nov 22, 2022
@rameyer
Copy link
Member Author

rameyer commented Nov 23, 2022

I haven't tested it so I can't answer this yet!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lboogaard @rameyer