New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

company_not_found raises an UnexpectedError when it should raise a ResourceNotFound error #222

Open

hassa opened this issue Apr 8, 2020 · 0 comments · May be fixed by #227

hassa commented Apr 8, 2020

We expected company_not_found to raise a ResourceNotFound, but currently it raises an UnexpectedError

We tracked this down to:
https://github.com/intercom/python-intercom/blob/master/intercom/errors.py#L68

I think company_not_found just needs to be mapped to ResourceNotFound

from intercom.client import Client

intercom = Client(personal_access_token='YOUR TOKEN')

try:
    intercom.companies.find(company_id='does not exist')
except Exception as e:
    print(type(e))

<class 'intercom.errors.UnexpectedError'>

The text was updated successfully, but these errors were encountered:

maldn linked a pull request

that will close this issue

use ResourceNotFound for error code 'company_not_found' #227

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment