Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creating and Updating a Company - only companyId should be required #379

Open
akherr opened this issue Aug 3, 2023 · 0 comments
Open

Creating and Updating a Company - only companyId should be required #379

akherr opened this issue Aug 3, 2023 · 0 comments

Comments

@akherr
Copy link

akherr commented Aug 3, 2023

Version info

  • intercom-node version: 4.0.0
  • Node version: 16

Expected behavior

Using the create and update methods for the Company model should only require companyId.

Actual behavior

All of the parameters in the create and update methods for the Company are required.

interface CreateCompanyData {
    createdAt: Timestamp;
    companyId: string;
    name: string;
    monthlySpend: number;
    plan: string;
    size: number;
    website: string;
    industry: string;
    customAttributes: JavascriptObject;
}
declare type UpdateCompanyData = CreateCompanyData;

This interface should reflect what is defined in the API docs, with having all but companyId optional.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant