Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better error handling of invalid search queries #345

Open
colmdoyle opened this issue Jan 30, 2023 · 1 comment
Open

Better error handling of invalid search queries #345

colmdoyle opened this issue Jan 30, 2023 · 1 comment

Comments

@colmdoyle
Copy link
Contributor

See #344 for some context.

@Alx101
Copy link

Alx101 commented Feb 2, 2023

Just recently ran into an issue because of this. Probably due to incorrect config, but any calls from the client fails with undefined error. After some digging it seems to be getting a 404 from the api, but because of this

return undefined;

the error is swallowed and completely hidden, at least a console.error or some specific error thrown would help for debugging.

Exceptions like these need to bubble up so it can be handled properly, and give some insight into what is wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants