Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cataloging contents of various intellij-elm forks #807

Open
BenjaminDebeerst opened this issue Apr 4, 2024 · 1 comment
Open

Cataloging contents of various intellij-elm forks #807

BenjaminDebeerst opened this issue Apr 4, 2024 · 1 comment

Comments

@BenjaminDebeerst
Copy link
Contributor

BenjaminDebeerst commented Apr 4, 2024

I went through https://github.com/intellij-elm/intellij-elm/network to see what changes different forks visible on GitHub have made. This should allow to provide a starting point to decide which of the changes might be interesting to be contributed to the mainline. I didn't go into detail to validate the contents/quality of the commits, taking mostly only the commit messages as the source of information. I hope this is helpful!

Many forks branch off of earlier version of the plugin, meaning that integrating them may be hard given the big changset in #785, but depending on the content it might still be worthwhile to port those.

Within the branching section, roughly ordered by relevance from my personal point of view.

Forking from 5.0.0-beta21 / 1d9f3d4

I.e. the forking from the latest version before transition to the new org.

ktoslek

totof99

1d9f3d4...309c91d

  • Version updates
    • plugin jetbrains dependencies
    • plugin build versions and target platform versions
    • java 17 for plugin build
    • gradle 7.4 --> 8.5
  • unit test fix (309c91d)
  • more changes branching from 83e20f0

hewison-chris

1d9f3d4...2478791

  • ConvertibleColor deprecation fix (0173f93)
  • Small fixes a01fc94 and 69afead
  • Java and Gradle version updates
  • Enable GitHub actions, removing deprecated GH actions settings 18f4c09
  • more changes branching from eafbfe8 (see below)

mostlyobvious

Enabling and some small improvements to github actions: 1d9f3d4...6f35ad5

utiliteez

Forking from eafbfe8 / c47cc5a / 83e20f0 (almost the same), versions 4.4.0-4.4.1

dillonkears

c47cc5a...977b257

This one is interesting because it integrates a bunch of changes from different contributors an branches

  • type hints, parameter inlays
  • some contributions from arian
    • removing bintray links
    • some test fixes
    • catch broken elm.json
    • fix saving null toolchain paths
  • add import on qualified completion

hewison-chris

Moving files / module renames: 21f48...hewison-chris:intellij-elm:move_files

ktoslek

  • A lot of stuff... 36 commits
    • 83e20f0...89bdf01
    • the total change set is huge: 323 changed files with 9,161 additions and 1,566 deletions
    • housekeeping (adapt release links, install instructions etc to fork)
    • Fixing some Lambdera issues
      • compiler path persistence
      • refactor of how lambdera compiles are invoked
    • other larger refactors
    • improvements / changes to watch mode
    • plugin build updates
    • ...

totof99

83e20f0...2ad3cfc

  • some EOL fix
  • fixing a rendering / coloring / locale issue

petteraas

These are commits showing up in petteraas repo but authored by klazuka, they don't seem complete but might be relevant

@cies
Copy link
Contributor

cies commented Apr 5, 2024

Hi @BenjaminDebeerst ! Thanks for the thorough overview. I have run through the network diagram myself, and tried to distill some PRs out of it, like #802, #803 and #805.

I've tried most of the branches you mention here, but --as you mention here-- it's sometimes very hard to land those changes on a recent branch from master. Especially when it concerns upgrades (dependency upgrade hell seems to be always just around the corner).

If you want to help distilling PRs out of the branches you mention above, that'd be greatly appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants