Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix error about ElmTestConfigurationFactory.getId() #781

Merged
merged 1 commit into from
Feb 17, 2022
Merged

Fix error about ElmTestConfigurationFactory.getId() #781

merged 1 commit into from
Feb 17, 2022

Conversation

karvanit
Copy link
Contributor

Use hardcoded string instead of falling back on getName().
Closes issue #776.

@karvanit
Fix error about ElmTestConfigurationFactory.getId()
4e62e59 
Use hardcoded string instead of falling back on getName().
Closes issue intellij-elm#776.
@janekx21
Copy link

Can this please be approved? @karvanit @FloWi

@klazuka
Copy link
Collaborator

klazuka commented Feb 17, 2022

Unfortunately due to the bintray issue, the project no longer builds. And sadly it requires updating a bunch of things like GrammarKit and IntelliJ, but that causes a bunch of failures. Someone would need to continue the work in #764 before we could do a new release.

@klazuka klazuka merged commit 83e20f0 into intellij-elm:master Feb 17, 2022
@clojj
Copy link
Contributor

clojj commented Feb 20, 2022

Unfortunately due to the bintray issue, the project no longer builds. And sadly it requires updating a bunch of things like GrammarKit and IntelliJ, but that causes a bunch of failures. Someone would need to continue the work in #764 before we could do a new release.

@klazuka
Hi Keith !
from the current IJ plugin platform I managed to renovate several things, fixed some deprecations, improved compiler toolwindow and integrated elm-review
would you be interested in a PR ?
The missing thing would be to finalize the new publishing of the plugin, should be straightforward since it is using latest IJ gradle build.

@karvanit karvanit deleted the fix-deprecation-warning-for-getId branch February 21, 2022 08:03
@klazuka
Copy link
Collaborator

klazuka commented Feb 22, 2022

@clojj yeah, post the PR, that sounds good.

@cies cies linked an issue Apr 4, 2024 that may be closed by this pull request
Deprecation warning for 'getId' #776
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deprecation warning for 'getId'
4 participants
@karvanit @janekx21 @klazuka @clojj