Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move pkg/topology to proper upstream #1379

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

move pkg/topology to proper upstream #1379

wants to merge 1 commit into from

Conversation

mythi
Copy link
Contributor

@mythi mythi commented Apr 13, 2023 •
edited

Fixes: #1366

@codecov-commenter
Copy link

codecov-commenter commented Apr 13, 2023 •
edited

Codecov Report

Merging #1379 (4447647) into main (6ab2833) will decrease coverage by 0.39%.
The diff coverage is 100.00%.

❗ Current head 4447647 differs from pull request most recent head d81cdd6. Consider uploading reports for the commit d81cdd6 to get more accurate results

@@            Coverage Diff             @@
##             main    #1379      +/-   ##
==========================================
- Coverage   50.77%   50.38%   -0.39%     
==========================================
  Files          44       44              
  Lines        5022     4896     -126     
==========================================
- Hits         2550     2467      -83     
+ Misses       2326     2289      -37     
+ Partials      146      140       -6
Impacted Files Coverage Δ
pkg/topology/topology.go 68.00% <100.00%> (+1.77%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mythi mythi force-pushed the PR-2023-017 branch 2 times, most recently from f9efadc to 104161b Compare April 17, 2023 06:49
@mythi
Copy link
Contributor Author

mythi commented Apr 18, 2023

keeping this in draft until we have a release for containers/nri-plugins

@mythi mythi closed this Apr 18, 2023
@mythi mythi reopened this Apr 18, 2023
@mythi
pkg/topology: get sysfs parsing from containers/nri-plugins
d81cdd6 
A proper upstream for the sysfs topology parsing is
containers/nri-plugins se we can drop the duplicated code.

At the same time, we no longer need to carry scripts/ttar
and the sys.ttar unpacking for the tests because the remaining
testdata becomes easier to maintain (the original testdata
contained PCI BDF paths that trigged issues).

Signed-off-by: Mikko Ylinen <mikko.ylinen@intel.com>
@mythi mythi mentioned this pull request Jul 25, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kad kad Awaiting requested review from kad kad will be requested when the pull request is marked ready for review kad is a code owner

@bart0sh bart0sh Awaiting requested review from bart0sh bart0sh will be requested when the pull request is marked ready for review bart0sh is a code owner

@tkatila tkatila Awaiting requested review from tkatila tkatila will be requested when the pull request is marked ready for review tkatila is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

drop pkg/topology and use it from containers/nri-plugins repo
2 participants
@mythi @codecov-commenter