Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Disabling Image Name Validation #1305

Open
DWSR opened this issue Jan 14, 2023 · 4 comments
Open

Allow Disabling Image Name Validation #1305

DWSR opened this issue Jan 14, 2023 · 4 comments

Comments

@DWSR
Copy link

DWSR commented Jan 14, 2023

This check has the potential to break some workflows for mirroring images to private registries such as kbld.

It would be helpful to have an option to disable the image name validation since this it's only a sanity check and not a functional test.

@mythi
Copy link
Contributor

mythi commented Jan 15, 2023

potential to break some workflows for mirroring images to private registries such as kbld.

the registry / org are not checked by the validation. the image name validation checks the images matches <image-name>.Dockerfile (or make <image-name>) from this repo.

@DWSR
Copy link
Author

DWSR commented Jan 15, 2023

@mythi Yes, exactly. Checking the name of the image isn't exactly particularly effective (Rook, by contrast, checks that the supplied Ceph image actually has Ceph installed and of a sufficient version), IMO.

I'm not asking for the default behaviour to change, but rather a way to turn off this validation with a CLI arg or environment variable (or both).

@mythi
Copy link
Contributor

mythi commented Jan 16, 2023

We may need to revisit the validation also for other reasons (e.g., to allow users to use image sha's as versions) at some point. Is there anything that's blocking you right now?

@DWSR
Copy link
Author

DWSR commented Jan 16, 2023

@mythi Yes, currently this blocks me from air-gapping my cluster using my current workflows (via kbld and imgpkg).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants