New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow Disabling Image Name Validation #1305
Comments
the registry / org are not checked by the validation. the image name validation checks the images matches |
@mythi Yes, exactly. Checking the name of the image isn't exactly particularly effective (Rook, by contrast, checks that the supplied Ceph image actually has Ceph installed and of a sufficient version), IMO. I'm not asking for the default behaviour to change, but rather a way to turn off this validation with a CLI arg or environment variable (or both). |
We may need to revisit the validation also for other reasons (e.g., to allow users to use image sha's as versions) at some point. Is there anything that's blocking you right now? |
@mythi Yes, currently this blocks me from air-gapping my cluster using my current workflows (via kbld and imgpkg). |
This check has the potential to break some workflows for mirroring images to private registries such as kbld.
It would be helpful to have an option to disable the image name validation since this it's only a sanity check and not a functional test.
The text was updated successfully, but these errors were encountered: