Skip to content
This repository has been archived by the owner on May 9, 2024. It is now read-only.

Warning during compilation #521

Open
Devjiu opened this issue Jun 12, 2023 · 0 comments
Open

Warning during compilation #521

Devjiu opened this issue Jun 12, 2023 · 0 comments

Comments

@Devjiu
Copy link
Contributor

Devjiu commented Jun 12, 2023

There are too many warnings generated during build. It makes cmake/make logs difficult to read and understand exact reason of an issue.

One of possible solutions is to add job with -Werror.

Also some warns are generated during cmake configuration, I am not sure it's covered with Werror option.

Currently we have such errors:

during cmake:

CMake Warning (dev) at omniscidb/Tests/CMakeLists.txt:272:
  Syntax Warning in cmake code at column 204

  Argument not separated from preceding token by whitespace.
This warning is for project developers.  Use -Wno-dev to suppress it.

This warning generated due to enabling of windows build and issued with cmd \s which have specific inner quotes handling. Maybe we can remove \s and have more difficult escaping for quotes from windows point of view, but it will not generate a warn?

during make:

In file included from /localdisk/dmitriim/hdk/omniscidb/QueryEngine/RelAlgDagBuilder.h:36,
                 from /localdisk/dmitriim/hdk/omniscidb/QueryEngine/RelAlgExecutionUnit.h:31,
                 from /localdisk/dmitriim/hdk/omniscidb/QueryEngine/InputMetadata.h:22,
                 from /localdisk/dmitriim/hdk/omniscidb/QueryEngine/JoinFilterPushDown.h:22,
                 from /localdisk/dmitriim/hdk/omniscidb/QueryEngine/Descriptors/RelAlgExecutionDescriptor.h:19,
                 from /localdisk/dmitriim/hdk/omniscidb/QueryEngine/ArrowResultSet.h:20,
                 from /localdisk/dmitriim/hdk/omniscidb/Tests/TestHelpers.h:21,
                 from /localdisk/dmitriim/hdk/omniscidb/Tests/Quantile/QuantileCpuTest.cpp:19:
/localdisk/dmitriim/hdk/omniscidb/IR/Node.h: In member function 'virtual const std::string& hdk::ir::TranslatedJoin::getFieldName(size_t) const':
/localdisk/dmitriim/hdk/omniscidb/IR/Node.h:594:76: warning: no return statement in function returning non-void [-Wreturn-type]
  594 |   const std::string& getFieldName(size_t i) const override { CHECK(false); }
      |                                                                            ^
In file included from /localdisk/dmitriim/hdk/omniscidb/QueryEngine/RelAlgDagBuilder.h:36,
                 from /localdisk/dmitriim/hdk/omniscidb/QueryEngine/RelAlgExecutionUnit.h:31,
                 from /localdisk/dmitriim/hdk/omniscidb/QueryEngine/InputMetadata.h:22,
                 from /localdisk/dmitriim/hdk/omniscidb/QueryEngine/JoinFilterPushDown.h:22,
                 from /localdisk/dmitriim/hdk/omniscidb/QueryEngine/Descriptors/RelAlgExecutionDescriptor.h:19,
                 from /localdisk/dmitriim/hdk/omniscidb/QueryEngine/ArrowResultSet.h:20,
                 from /localdisk/dmitriim/hdk/omniscidb/Tests/TestHelpers.h:21,
                 from /localdisk/dmitriim/hdk/omniscidb/Tests/ParallelSortTest.cpp:4:
/localdisk/dmitriim/hdk/omniscidb/IR/Node.h: In member function 'virtual const std::string& hdk::ir::TranslatedJoin::getFieldName(size_t) const':
/localdisk/dmitriim/hdk/omniscidb/IR/Node.h:594:76: warning: no return statement in function returning non-void [-Wreturn-type]
  594 |   const std::string& getFieldName(size_t i) const override { CHECK(false); }
      |                                                                            ^



/localdisk/dmitriim/hdk/omniscidb/QueryEngine/DateTruncate.cpp:75:30: warning: 'always_inline' function might not be inlinable [-Wattribute
]
   75 | ALWAYS_INLINE DEVICE int64_t datetrunc_week(int64_t timeval) {
      |                              ^~~~~~~~~~~~~~
/localdisk/dmitriim/hdk/omniscidb/QueryEngine/DateTruncate.cpp:75:30: warning: 'always_inline' function might not be inlinable [-Wattribute
]
/localdisk/dmitriim/hdk/omniscidb/QueryEngine/DateTruncate.cpp:75:30: warning: 'always_inline' function might not be inlinable [-Wattribute
]
/localdisk/dmitriim/hdk/omniscidb/QueryEngine/DateTruncate.cpp:324:1: warning: 'always_inline' function might not be inlinable [-Wattribute
]
  324 | DateTruncateHighPrecisionToDateNullable(const int64_t timeval,
      | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/localdisk/dmitriim/hdk/omniscidb/QueryEngine/DateTruncate.cpp:319:1: warning: 'always_inline' function might not be inlinable [-Wattribute
]
  319 | DateTruncateHighPrecisionToDate(const int64_t timeval, const int64_t scale) {
      | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/localdisk/dmitriim/hdk/omniscidb/QueryEngine/DateTruncate.cpp:262:21: warning: 'always_inline' function might not be inlinable [-Wattributes]
  262 | DATE_TRUNC_FUNC_JIT(datetrunc_millennium)
      |                     ^~~~~~~~~~~~~~~~~~~~
/localdisk/dmitriim/hdk/omniscidb/QueryEngine/DateTruncate.cpp:39:58: note: in definition of macro 'DATE_TRUNC_FUNC_JIT'
   39 |   extern "C" RUNTIME_EXPORT ALWAYS_INLINE DEVICE int64_t funcname(int64_t timeval) { \
      |                                                          ^~~~~~~~
/localdisk/dmitriim/hdk/omniscidb/QueryEngine/DateTruncate.cpp:245:21: warning: 'always_inline' function might not be inlinable [-Wattributes]
  245 | DATE_TRUNC_FUNC_JIT(datetrunc_century)
      |                     ^~~~~~~~~~~~~~~~~
/localdisk/dmitriim/hdk/omniscidb/QueryEngine/DateTruncate.cpp:39:58: note: in definition of macro 'DATE_TRUNC_FUNC_JIT'
   39 |   extern "C" RUNTIME_EXPORT ALWAYS_INLINE DEVICE int64_t funcname(int64_t timeval) { \
      |                                                          ^~~~~~~~
/localdisk/dmitriim/hdk/omniscidb/QueryEngine/DateTruncate.cpp:235:21: warning: 'always_inline' function might not be inlinable [-Wattributes]
  235 | DATE_TRUNC_FUNC_JIT(datetrunc_decade)
      |                     ^~~~~~~~~~~~~~~~
/localdisk/dmitriim/hdk/omniscidb/QueryEngine/DateTruncate.cpp:39:58: note: in definition of macro 'DATE_TRUNC_FUNC_JIT'
   39 |   extern "C" RUNTIME_EXPORT ALWAYS_INLINE DEVICE int64_t funcname(int64_t timeval) { \
      |                                                          ^~~~~~~~
/localdisk/dmitriim/hdk/omniscidb/QueryEngine/DateTruncate.cpp:215:21: warning: 'always_inline' function might not be inlinable [-Wattributes]
  215 | DATE_TRUNC_FUNC_JIT(datetrunc_year)
      |                     ^~~~~~~~~~~~~~
/localdisk/dmitriim/hdk/omniscidb/QueryEngine/DateTruncate.cpp:39:58: note: in definition of macro 'DATE_TRUNC_FUNC_JIT'
   39 |   extern "C" RUNTIME_EXPORT ALWAYS_INLINE DEVICE int64_t funcname(int64_t timeval) { \
      |                                                          ^~~~~~~~
/localdisk/dmitriim/hdk/omniscidb/QueryEngine/DateTruncate.cpp:188:21: warning: 'always_inline' function might not be inlinable [-Wattributes]
  188 | DATE_TRUNC_FUNC_JIT(datetrunc_quarter)
      |                     ^~~~~~~~~~~~~~~~~
/localdisk/dmitriim/hdk/omniscidb/QueryEngine/DateTruncate.cpp:39:58: note: in definition of macro 'DATE_TRUNC_FUNC_JIT'
   39 |   extern "C" RUNTIME_EXPORT ALWAYS_INLINE DEVICE int64_t funcname(int64_t timeval) { \
      |                                                          ^~~~~~~~
/localdisk/dmitriim/hdk/omniscidb/QueryEngine/DateTruncate.cpp:143:21: warning: 'always_inline' function might not be inlinable [-Wattributes]
  143 | DATE_TRUNC_FUNC_JIT(datetrunc_month)
      |                     ^~~~~~~~~~~~~~~
/localdisk/dmitriim/hdk/omniscidb/QueryEngine/DateTruncate.cpp:39:58: note: in definition of macro 'DATE_TRUNC_FUNC_JIT'
   39 |   extern "C" RUNTIME_EXPORT ALWAYS_INLINE DEVICE int64_t funcname(int64_t timeval) { \
      |                                                          ^~~~~~~~
/localdisk/dmitriim/hdk/omniscidb/QueryEngine/DateTruncate.cpp:91:1: warning: 'always_inline' function might not be inlinable [-Wattributes]
   91 | datetrunc_week_saturday(int64_t timeval) {
      | ^~~~~~~~~~~~~~~~~~~~~~~
/localdisk/dmitriim/hdk/omniscidb/QueryEngine/DateTruncate.cpp:86:1: warning: 'always_inline' function might not be inlinable [-Wattributes]
   86 | datetrunc_week_sunday(int64_t timeval) {
      | ^~~~~~~~~~~~~~~~~~~~~
/localdisk/dmitriim/hdk/omniscidb/QueryEngine/DateTruncate.cpp:81:1: warning: 'always_inline' function might not be inlinable [-Wattributes]
   81 | datetrunc_week_monday(int64_t timeval) {
      | ^~~~~~~~~~~~~~~~~~~~~
/localdisk/dmitriim/hdk/omniscidb/QueryEngine/DateTruncate.cpp:65:21: warning: 'always_inline' function might not be inlinable [-Wattribute
]
   65 | DATE_TRUNC_FUNC_JIT(datetrunc_day)
      |                     ^~~~~~~~~~~~~
/localdisk/dmitriim/hdk/omniscidb/QueryEngine/DateTruncate.cpp:39:58: note: in definition of macro 'DATE_TRUNC_FUNC_JIT'
   39 |   extern "C" RUNTIME_EXPORT ALWAYS_INLINE DEVICE int64_t funcname(int64_t timeval) { \
      |                                                          ^~~~~~~~
/localdisk/dmitriim/hdk/omniscidb/QueryEngine/DateTruncate.cpp:59:21: warning: 'always_inline' function might not be inlinable [-Wattribute
]
   59 | DATE_TRUNC_FUNC_JIT(datetrunc_quarterday)
      |                     ^~~~~~~~~~~~~~~~~~~~
/localdisk/dmitriim/hdk/omniscidb/QueryEngine/DateTruncate.cpp:39:58: note: in definition of macro 'DATE_TRUNC_FUNC_JIT'
   39 |   extern "C" RUNTIME_EXPORT ALWAYS_INLINE DEVICE int64_t funcname(int64_t timeval) { \
      |                                                          ^~~~~~~~
/localdisk/dmitriim/hdk/omniscidb/QueryEngine/DateTruncate.cpp:53:21: warning: 'always_inline' function might not be inlinable [-Wattribute
]
   53 | DATE_TRUNC_FUNC_JIT(datetrunc_hour)
      |                     ^~~~~~~~~~~~~~
/localdisk/dmitriim/hdk/omniscidb/QueryEngine/DateTruncate.cpp:39:58: note: in definition of macro 'DATE_TRUNC_FUNC_JIT'
   39 |   extern "C" RUNTIME_EXPORT ALWAYS_INLINE DEVICE int64_t funcname(int64_t timeval) { \
      |                                                          ^~~~~~~~
/localdisk/dmitriim/hdk/omniscidb/QueryEngine/DateTruncate.cpp:47:21: warning: 'always_inline' function might not be inlinable [-Wattribute
]
   47 | DATE_TRUNC_FUNC_JIT(datetrunc_minute)
      |                     ^~~~~~~~~~~~~~~~
/localdisk/dmitriim/hdk/omniscidb/QueryEngine/DateTruncate.cpp:39:58: note: in definition of macro 'DATE_TRUNC_FUNC_JIT'
   39 |   extern "C" RUNTIME_EXPORT ALWAYS_INLINE DEVICE int64_t funcname(int64_t timeval) { \
      |                                                          ^~~~~~~~



In file included from /localdisk/dmitriim/hdk/omniscidb/IR/Node.cpp:8:
/localdisk/dmitriim/hdk/omniscidb/IR/Node.h: In member function 'virtual const std::string& hdk::ir::TranslatedJoin::getFieldName(size_t) const':
/localdisk/dmitriim/hdk/omniscidb/IR/Node.h:594:76: warning: no return statement in function returning non-void [-Wreturn-type]
  594 |   const std::string& getFieldName(size_t i) const override { CHECK(false); }
      |                                                                            ^



In file included from /localdisk/dmitriim/hdk/omniscidb/QueryEngine/RelAlgDagBuilder.h:36,
                 from /localdisk/dmitriim/hdk/omniscidb/QueryEngine/RelAlgExecutionUnit.h:31,
                 from /localdisk/dmitriim/hdk/omniscidb/QueryEngine/InputMetadata.h:22,
                 from /localdisk/dmitriim/hdk/omniscidb/QueryEngine/JoinFilterPushDown.h:22,
                 from /localdisk/dmitriim/hdk/omniscidb/QueryEngine/Descriptors/RelAlgExecutionDescriptor.h:19,
                 from /localdisk/dmitriim/hdk/omniscidb/IR/Expr.cpp:11:
/localdisk/dmitriim/hdk/omniscidb/IR/Node.h: In member function 'virtual const std::string& hdk::ir::TranslatedJoin::getFieldName(size_t) const':
/localdisk/dmitriim/hdk/omniscidb/IR/Node.h:594:76: warning: no return statement in function returning non-void [-Wreturn-type]
  594 |   const std::string& getFieldName(size_t i) const override { CHECK(false); }
      |                                                                            ^
In file included from /localdisk/dmitriim/hdk/omniscidb/QueryEngine/RelAlgDagBuilder.h:36,
                 from /localdisk/dmitriim/hdk/omniscidb/QueryEngine/RelAlgExecutionUnit.h:31,
                 from /localdisk/dmitriim/hdk/omniscidb/QueryEngine/InputMetadata.h:22,
                 from /localdisk/dmitriim/hdk/omniscidb/QueryEngine/JoinFilterPushDown.h:22,
                 from /localdisk/dmitriim/hdk/omniscidb/QueryEngine/Descriptors/RelAlgExecutionDescriptor.h:19,
                 from /localdisk/dmitriim/hdk/omniscidb/QueryEngine/ArrowResultSet.h:20,
                 from /localdisk/dmitriim/hdk/omniscidb/Tests/TestHelpers.h:21,
                 from /localdisk/dmitriim/hdk/omniscidb/Tests/StringTransformTest.cpp:20:
/localdisk/dmitriim/hdk/omniscidb/IR/Node.h: In member function 'virtual const std::string& hdk::ir::TranslatedJoin::getFieldName(size_t) const':
/localdisk/dmitriim/hdk/omniscidb/IR/Node.h:594:76: warning: no return statement in function returning non-void [-Wreturn-type]
  594 |   const std::string& getFieldName(size_t i) const override { CHECK(false); }
      |                                                                            ^
In file included from /localdisk/dmitriim/hdk/omniscidb/QueryEngine/RelAlgDagBuilder.h:36,
                 from /localdisk/dmitriim/hdk/omniscidb/QueryEngine/RelAlgExecutionUnit.h:31,
                 from /localdisk/dmitriim/hdk/omniscidb/QueryEngine/InputMetadata.h:22,
                 from /localdisk/dmitriim/hdk/omniscidb/QueryEngine/JoinFilterPushDown.h:22,
                 from /localdisk/dmitriim/hdk/omniscidb/QueryEngine/Descriptors/RelAlgExecutionDescriptor.h:19,
                 from /localdisk/dmitriim/hdk/omniscidb/QueryEngine/ArrowResultSet.h:20,
                 from /localdisk/dmitriim/hdk/omniscidb/Tests/TestHelpers.h:21,
                 from /localdisk/dmitriim/hdk/omniscidb/Tests/Shared/ThreadingTest.cpp:2:
/localdisk/dmitriim/hdk/omniscidb/IR/Node.h: In member function 'virtual const std::string& hdk::ir::TranslatedJoin::getFieldName(size_t) const':
/localdisk/dmitriim/hdk/omniscidb/IR/Node.h:594:76: warning: no return statement in function returning non-void [-Wreturn-type]
  594 |   const std::string& getFieldName(size_t i) const override { CHECK(false); }
      |                                                                            ^
In file included from /localdisk/dmitriim/hdk/omniscidb/QueryEngine/RelAlgDagBuilder.h:36,
                 from /localdisk/dmitriim/hdk/omniscidb/QueryEngine/RelAlgExecutionUnit.h:31,
                 from /localdisk/dmitriim/hdk/omniscidb/QueryEngine/InputMetadata.h:22,
                 from /localdisk/dmitriim/hdk/omniscidb/QueryEngine/JoinFilterPushDown.h:22,
                 from /localdisk/dmitriim/hdk/omniscidb/QueryEngine/Descriptors/RelAlgExecutionDescriptor.h:19,
                 from /localdisk/dmitriim/hdk/omniscidb/QueryEngine/ArrowResultSet.h:20,
                 from /localdisk/dmitriim/hdk/omniscidb/Tests/TestHelpers.h:21,
                 from /localdisk/dmitriim/hdk/omniscidb/Tests/Shared/ThreadingTest.cpp:2,
                 from /localdisk/dmitriim/hdk/omniscidb/Tests/Shared/ThreadingTestStd.cpp:7:
/localdisk/dmitriim/hdk/omniscidb/IR/Node.h: In member function 'virtual const std::string& hdk::ir::TranslatedJoin::getFieldName(size_t) const':
/localdisk/dmitriim/hdk/omniscidb/IR/Node.h:594:76: warning: no return statement in function returning non-void [-Wreturn-type]
  594 |   const std::string& getFieldName(size_t i) const override { CHECK(false); }
      |                                                                            ^



In file included from /localdisk/dmitriim/hdk/omniscidb/QueryEngine/RelAlgDagBuilder.h:36,
                 from /localdisk/dmitriim/hdk/omniscidb/QueryEngine/RelAlgExecutionUnit.h:31,
                 from /localdisk/dmitriim/hdk/omniscidb/QueryEngine/InputMetadata.h:22,
                 from /localdisk/dmitriim/hdk/omniscidb/QueryEngine/JoinFilterPushDown.h:22,
                 from /localdisk/dmitriim/hdk/omniscidb/QueryEngine/Descriptors/RelAlgExecutionDescriptor.h:19,
                 from /localdisk/dmitriim/hdk/omniscidb/QueryEngine/ArrowResultSet.h:20,
                 from /localdisk/dmitriim/hdk/omniscidb/Tests/TestHelpers.h:21,
                 from /localdisk/dmitriim/hdk/omniscidb/Tests/Shared/DateTimeUtilsTest.cpp:19:
/localdisk/dmitriim/hdk/omniscidb/IR/Node.h: In member function 'virtual const std::string& hdk::ir::TranslatedJoin::getFieldName(size_t) const':
/localdisk/dmitriim/hdk/omniscidb/IR/Node.h:594:76: warning: no return statement in function returning non-void [-Wreturn-type]
  594 |   const std::string& getFieldName(size_t i) const override { CHECK(false); }
      |                                                                            ^



/localdisk/dmitriim/hdk/omniscidb/Utils/ExtractFromTime.cpp:199:30: warning: 'always_inline' function might not be inlinable [-Wattributes]
  199 | ALWAYS_INLINE DEVICE int64_t extract_week(const int64_t timeval) {
      |                              ^~~~~~~~~~~~
/localdisk/dmitriim/hdk/omniscidb/Utils/ExtractFromTime.cpp:199:30: warning: 'always_inline' function might not be inlinable [-Wattributes]
/localdisk/dmitriim/hdk/omniscidb/Utils/ExtractFromTime.cpp:199:30: warning: 'always_inline' function might not be inlinable [-Wattributes]
/localdisk/dmitriim/hdk/omniscidb/Utils/ExtractFromTime.cpp:258:1: warning: 'always_inline' function might not be inlinable [-Wattributes]
  258 | extract_year(const int64_t timeval) {
      | ^~~~~~~~~~~~
/localdisk/dmitriim/hdk/omniscidb/Utils/ExtractFromTime.cpp:244:1: warning: 'always_inline' function might not be inlinable [-Wattributes]
  244 | extract_quarter(const int64_t timeval) {
      | ^~~~~~~~~~~~~~~
/localdisk/dmitriim/hdk/omniscidb/Utils/ExtractFromTime.cpp:231:1: warning: 'always_inline' function might not be inlinable [-Wattributes]
  231 | extract_month(const int64_t timeval) {
      | ^~~~~~~~~~~~~
/localdisk/dmitriim/hdk/omniscidb/Utils/ExtractFromTime.cpp:226:1: warning: 'always_inline' function might not be inlinable [-Wattributes]
  226 | extract_week_saturday(const int64_t timeval) {
      | ^~~~~~~~~~~~~~~~~~~~~
/localdisk/dmitriim/hdk/omniscidb/Utils/ExtractFromTime.cpp:221:1: warning: 'always_inline' function might not be inlinable [-Wattributes]
  221 | extract_week_sunday(const int64_t timeval) {
      | ^~~~~~~~~~~~~~~~~~~
/localdisk/dmitriim/hdk/omniscidb/Utils/ExtractFromTime.cpp:216:1: warning: 'always_inline' function might not be inlinable [-Wattributes]
  216 | extract_week_monday(const int64_t timeval) {
      | ^~~~~~~~~~~~~~~~~~~
/localdisk/dmitriim/hdk/omniscidb/Utils/ExtractFromTime.cpp:189:1: warning: 'always_inline' function might not be inlinable [-Wattributes]
  189 | extract_day_of_year(const int64_t timeval) {
      | ^~~~~~~~~~~~~~~~~~~
/localdisk/dmitriim/hdk/omniscidb/Utils/ExtractFromTime.cpp:179:1: warning: 'always_inline' function might not be inlinable [-Wattributes]
  179 | extract_day(const int64_t timeval) {
      | ^~~~~~~~~~~
/localdisk/dmitriim/hdk/omniscidb/Utils/ExtractFromTime.cpp:173:1: warning: 'always_inline' function might not be inlinable [-Wattributes]
  173 | extract_isodow(const int64_t timeval) {
      | ^~~~~~~~~~~~~~
/localdisk/dmitriim/hdk/omniscidb/Utils/ExtractFromTime.cpp:167:1: warning: 'always_inline' function might not be inlinable [-Wattributes]
  167 | extract_dateepoch(const int64_t timeval) {
      | ^~~~~~~~~~~~~~~~~
/localdisk/dmitriim/hdk/omniscidb/Utils/ExtractFromTime.cpp:162:1: warning: 'always_inline' function might not be inlinable [-Wattributes]
  162 | extract_epoch(const int64_t timeval) {
      | ^~~~~~~~~~~~~
/localdisk/dmitriim/hdk/omniscidb/Utils/ExtractFromTime.cpp:92:1: warning: 'always_inline' function might not be inlinable [-Wattributes]
   92 | extract_quarterday(const int64_t lcltime) {
      | ^~~~~~~~~~~~~~~~~~
/localdisk/dmitriim/hdk/omniscidb/Utils/ExtractFromTime.cpp:86:1: warning: 'always_inline' function might not be inlinable [-Wattributes]
   86 | extract_dow(const int64_t lcltime) {
      | ^~~~~~~~~~~
/localdisk/dmitriim/hdk/omniscidb/Utils/ExtractFromTime.cpp:80:1: warning: 'always_inline' function might not be inlinable [-Wattributes]
   80 | extract_nanosecond(const int64_t lcltime) {
      | ^~~~~~~~~~~~~~~~~~
/localdisk/dmitriim/hdk/omniscidb/Utils/ExtractFromTime.cpp:75:1: warning: 'always_inline' function might not be inlinable [-Wattributes]
   75 | extract_microsecond(const int64_t lcltime) {
      | ^~~~~~~~~~~~~~~~~~~
/localdisk/dmitriim/hdk/omniscidb/Utils/ExtractFromTime.cpp:70:1: warning: 'always_inline' function might not be inlinable [-Wattributes]
   70 | extract_millisecond(const int64_t lcltime) {
      | ^~~~~~~~~~~~~~~~~~~
/localdisk/dmitriim/hdk/omniscidb/Utils/ExtractFromTime.cpp:65:1: warning: 'always_inline' function might not be inlinable [-Wattributes]
   65 | extract_second(const int64_t lcltime) {
      | ^~~~~~~~~~~~~~
/localdisk/dmitriim/hdk/omniscidb/Utils/ExtractFromTime.cpp:60:1: warning: 'always_inline' function might not be inlinable [-Wattributes]
   60 | extract_minute(const int64_t lcltime) {
      | ^~~~~~~~~~~~~~
/localdisk/dmitriim/hdk/omniscidb/Utils/ExtractFromTime.cpp:55:1: warning: 'always_inline' function might not be inlinable [-Wattributes]
   55 | extract_hour(const int64_t lcltime) {
      | ^~~~~~~~~~~~



In file included from /localdisk/dmitriim/hdk/omniscidb/QueryEngine/RelAlgDagBuilder.h:36,
                 from /localdisk/dmitriim/hdk/omniscidb/QueryEngine/RelAlgExecutionUnit.h:31,
                 from /localdisk/dmitriim/hdk/omniscidb/QueryEngine/InputMetadata.h:22,
                 from /localdisk/dmitriim/hdk/omniscidb/QueryEngine/JoinFilterPushDown.h:22,
                 from /localdisk/dmitriim/hdk/omniscidb/QueryEngine/Descriptors/RelAlgExecutionDescriptor.h:19,
                 from /localdisk/dmitriim/hdk/omniscidb/QueryEngine/ArrowResultSet.h:20,
                 from /localdisk/dmitriim/hdk/omniscidb/Tests/TestHelpers.h:21,
                 from /localdisk/dmitriim/hdk/omniscidb/Tests/EncoderTest.cpp:29:
/localdisk/dmitriim/hdk/omniscidb/IR/Node.h: In member function 'virtual const std::string& hdk::ir::TranslatedJoin::getFieldName(size_t) const':
/localdisk/dmitriim/hdk/omniscidb/IR/Node.h:594:76: warning: no return statement in function returning non-void [-Wreturn-type]
  594 |   const std::string& getFieldName(size_t i) const override { CHECK(false); }
      |                                                                            ^



In file included from /localdisk/dmitriim/hdk/omniscidb/QueryEngine/RelAlgDagBuilder.h:36,
                 from /localdisk/dmitriim/hdk/omniscidb/QueryEngine/RelAlgExecutionUnit.h:31,
                 from /localdisk/dmitriim/hdk/omniscidb/QueryEngine/InputMetadata.h:22,
                 from /localdisk/dmitriim/hdk/omniscidb/QueryEngine/JoinFilterPushDown.h:22,
                 from /localdisk/dmitriim/hdk/omniscidb/QueryEngine/Descriptors/RelAlgExecutionDescriptor.h:19,
                 from /localdisk/dmitriim/hdk/omniscidb/QueryEngine/ArrowResultSet.h:20,
                 from /localdisk/dmitriim/hdk/omniscidb/Tests/TestHelpers.h:21,
                 from /localdisk/dmitriim/hdk/omniscidb/Tests/UtilTest.cpp:18:
/localdisk/dmitriim/hdk/omniscidb/IR/Node.h: In member function 'virtual const std::string& hdk::ir::TranslatedJoin::getFieldName(size_t) const':
/localdisk/dmitriim/hdk/omniscidb/IR/Node.h:594:76: warning: no return statement in function returning non-void [-Wreturn-type]
  594 |   const std::string& getFieldName(size_t i) const override { CHECK(false); }
      |                                                                            ^

/localdisk/dmitriim/hdk/omniscidb/ResultSet/TargetValue.cpp:7:9: warning: #pragma once in main file
    7 | #pragma once
      |         ^~~~
[ 41%] Linking CXX executable UtilTest
[ 41%] Built target UtilTest
/localdisk/dmitriim/hdk/omniscidb/ResultSet/ResultSetStorage.cpp:62:6: warning: 'always_inline' function might not be inlinable [-Wattributes]
   62 | void fill_empty_key_64(int64_t* key_ptr_i64, const size_t key_count) {
      |      ^~~~~~~~~~~~~~~~~
/localdisk/dmitriim/hdk/omniscidb/ResultSet/ResultSetStorage.cpp:55:6: warning: 'always_inline' function might not be inlinable [-Wattributes]
   55 | void fill_empty_key_32(int32_t* key_ptr_i32, const size_t key_count) {
      |      ^~~~~~~~~~~~~~~~~
In file included from /localdisk/dmitriim/hdk/omniscidb/QueryEngine/RelAlgDagBuilder.h:36,
                 from /localdisk/dmitriim/hdk/omniscidb/QueryEngine/RelAlgExecutionUnit.h:31,
                 from /localdisk/dmitriim/hdk/omniscidb/QueryEngine/InputMetadata.h:22,
                 from /localdisk/dmitriim/hdk/omniscidb/QueryEngine/JoinFilterPushDown.h:22,
                 from /localdisk/dmitriim/hdk/omniscidb/QueryEngine/Descriptors/RelAlgExecutionDescriptor.h:19,
                 from /localdisk/dmitriim/hdk/omniscidb/QueryEngine/ArrowResultSet.h:20,
                 from /localdisk/dmitriim/hdk/omniscidb/Tests/TestHelpers.h:21,
                 from /localdisk/dmitriim/hdk/omniscidb/Tests/StringDictionaryTest.cpp:17:
/localdisk/dmitriim/hdk/omniscidb/IR/Node.h: In member function 'virtual const std::string& hdk::ir::TranslatedJoin::getFieldName(size_t) const':
/localdisk/dmitriim/hdk/omniscidb/IR/Node.h:594:76: warning: no return statement in function returning non-void [-Wreturn-type]
  594 |   const std::string& getFieldName(size_t i) const override { CHECK(false); }
      |                                                                            ^
In file included from /localdisk/dmitriim/hdk/omniscidb/QueryEngine/RelAlgDagBuilder.h:36,
                 from /localdisk/dmitriim/hdk/omniscidb/QueryEngine/RelAlgExecutionUnit.h:31,
                 from /localdisk/dmitriim/hdk/omniscidb/QueryEngine/InputMetadata.h:22,
                 from /localdisk/dmitriim/hdk/omniscidb/QueryEngine/JoinFilterPushDown.h:22,
                 from /localdisk/dmitriim/hdk/omniscidb/QueryEngine/Descriptors/RelAlgExecutionDescriptor.h:19,
                 from /localdisk/dmitriim/hdk/omniscidb/QueryEngine/ArrowResultSet.h:20,
                 from /localdisk/dmitriim/hdk/omniscidb/Tests/TestHelpers.h:21,
                 from /localdisk/dmitriim/hdk/omniscidb/Tests/StringDictionaryBenchmark.cpp:18:
/localdisk/dmitriim/hdk/omniscidb/IR/Node.h: In member function 'virtual const std::string& hdk::ir::TranslatedJoin::getFieldName(size_t) const':
/localdisk/dmitriim/hdk/omniscidb/IR/Node.h:594:76: warning: no return statement in function returning non-void [-Wreturn-type]
  594 |   const std::string& getFieldName(size_t i) const override { CHECK(false); }
      |                                                                            ^



In file included from /localdisk/dmitriim/hdk/omniscidb/QueryBuilder/QueryBuilder.h:10,
                 from /localdisk/dmitriim/hdk/omniscidb/QueryBuilder/QueryBuilder.cpp:7:
/localdisk/dmitriim/hdk/omniscidb/IR/Node.h: In member function 'virtual const std::string& hdk::ir::TranslatedJoin::getFieldName(size_t) const':
/localdisk/dmitriim/hdk/omniscidb/IR/Node.h:594:76: warning: no return statement in function returning non-void [-Wreturn-type]
  594 |   const std::string& getFieldName(size_t i) const override { CHECK(false); }
      |                                                                            ^



In file included from /localdisk/dmitriim/hdk/omniscidb/QueryOptimizer/CanonizeQuery.cpp:12:
/localdisk/dmitriim/hdk/omniscidb/IR/Node.h: In member function 'virtual const std::string& hdk::ir::TranslatedJoin::getFieldName(size_t) const':
/localdisk/dmitriim/hdk/omniscidb/IR/Node.h:594:76: warning: no return statement in function returning non-void [-Wreturn-type]
  594 |   const std::string& getFieldName(size_t i) const override { CHECK(false); }
      |                                                                            ^



/localdisk/dmitriim/hdk/omniscidb/QueryEngine/CardinalityEstimator.cpp: In function 'RelAlgExecutionUnit create_ndv_execution_unit(const RelAlgExecutionUnit&, SchemaProvider*, const Config&, int64_t)':
/localdisk/dmitriim/hdk/omniscidb/QueryEngine/CardinalityEstimator.cpp:73:26: warning: comparison of integer expressions of different signedness: 'size_t' {aka 'long unsigned int'} and 'const int64_t' {aka 'const long int'} [-Wsign-compare]
   73 |     if (tinfo->row_count < config.exec.group_by.large_ndv_threshold) {
      |         ~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from /localdisk/dmitriim/hdk/omniscidb/QueryEngine/Compiler/HelperFunctions.cpp:40:
/localdisk/dmitriim/hdk/omniscidb/QueryEngine/Optimization/AnnotateInternalFunctionsPass.h: In member function 'llvm::PreservedAnalyses AnnotateInternalFunctionsPass::run(llvm::LazyCallGraph::SCC&, llvm::CGSCCAnalysisManager&, llvm::LazyCallGraph&, llvm::CGSCCUpdateResult&)':
/localdisk/dmitriim/hdk/omniscidb/QueryEngine/Optimization/AnnotateInternalFunctionsPass.h:40:10: warning: variable 'updated_function_defs' set but not used [-Wunused-but-set-variable]
   40 |     bool updated_function_defs = false;
      |          ^~~~~~~~~~~~~~~~~~~~~
/localdisk/dmitriim/hdk/omniscidb/QueryEngine/Execute.cpp: In member function 'std::pair<std::unique_ptr<policy::ExecutionPolicy>, ExecutorDeviceType> Executor::getExecutionPolicyForTargets(const RelAlgExecutionUnit&, ExecutorDeviceType, const std::vector<InputTableInfo>&, size_t&)':
/localdisk/dmitriim/hdk/omniscidb/QueryEngine/Execute.cpp:1902:9: warning: second operand of conditional expression has no effect [-Wunused-value]
1902 |       ? "enabled"
      |         ^~~~~~~~~
/localdisk/dmitriim/hdk/omniscidb/QueryEngine/Execute.cpp:1903:9: warning: third operand of conditional expression has no effect [-Wunused-value]
1903 |       : "disabled";
      |         ^~~~~~~~~~



In file included from /localdisk/dmitriim/miniconda3/envs/omnisci-dev/include/boost/smart_ptr/detail/sp_thread_sleep.hpp:22,
                 from /localdisk/dmitriim/miniconda3/envs/omnisci-dev/include/boost/smart_ptr/detail/yield_k.hpp:23,
                 from /localdisk/dmitriim/miniconda3/envs/omnisci-dev/include/boost/smart_ptr/detail/spinlock_gcc_atomic.hpp:14,
                 from /localdisk/dmitriim/miniconda3/envs/omnisci-dev/include/boost/smart_ptr/detail/spinlock.hpp:42,
                 from /localdisk/dmitriim/miniconda3/envs/omnisci-dev/include/boost/smart_ptr/detail/spinlock_pool.hpp:25,
                 from /localdisk/dmitriim/miniconda3/envs/omnisci-dev/include/boost/smart_ptr/shared_ptr.hpp:29,
                 from /localdisk/dmitriim/miniconda3/envs/omnisci-dev/include/boost/property_map/vector_property_map.hpp:14,
                 from /localdisk/dmitriim/miniconda3/envs/omnisci-dev/include/boost/property_map/property_map.hpp:606,
                 from /localdisk/dmitriim/miniconda3/envs/omnisci-dev/include/boost/graph/adjacency_list.hpp:27,
                 from /localdisk/dmitriim/hdk/omniscidb/QueryEngine/RelAlgExecutionUnit.h:36,
                 from /localdisk/dmitriim/hdk/omniscidb/QueryEngine/InputMetadata.h:22,
                 from /localdisk/dmitriim/hdk/omniscidb/QueryEngine/CgenState.h:21,
                 from /localdisk/dmitriim/hdk/omniscidb/QueryEngine/Execute.h:44,
                 from /localdisk/dmitriim/hdk/build/omniscidb/QueryEngine/CMakeFiles/QueryEngine.dir/cmake_pch.hxx:5,
                 from <command-line>:
/localdisk/dmitriim/hdk/omniscidb/QueryEngine/TargetExprBuilder.cpp: In member function 'void TargetExprCodegen::codegenAggregate(RowFuncBuilder*, Executor*, const QueryMemoryDescriptor&, const CompilationOptions&, const std::vector<llvm::Value*, std::allocator<llvm::Value*> >&, const std::tuple<llvm::Value*, llvm::Value*>&, const std::vector<llvm::Value*, std::allocator<llvm::Value*> >&, llvm::Value*, llvm::Value*, llvm::Value*, int32_t) const':
/localdisk/dmitriim/hdk/omniscidb/QueryEngine/TargetExprBuilder.cpp:440:9: note: '#pragma message: Shared functions temporarily disabled for L0'
  440 |         BOOST_PRAGMA_MESSAGE("Shared functions temporarily disabled for L0")
      |         ^~~~~~~~~~~~~~~~~~~~
Devjiu added a commit that referenced this issue Jun 12, 2023
This commit is an initial step to remove warnings from build. Currenly
it's focused on linux build.

Also replaces ALWAYS_INLINE with FORCE_INLINE.

See also: #521

Signed-off-by: Dmitrii Makarenko <dmitrii.makarenko@intel.com>
Devjiu added a commit that referenced this issue Jun 14, 2023
This commit is an initial step to remove warnings from build. Currently
it's focused on linux build.

Always_inline attribute warning works incorrectly. In this case we want
to keep symbol and than inline it during target llvm ir optimisation.

See also: #521

Signed-off-by: Dmitrii Makarenko <dmitrii.makarenko@intel.com>
Devjiu added a commit that referenced this issue Jun 14, 2023
This commit is an initial step to remove warnings from build. Currently
it's focused on linux build.

Always_inline attribute warning works incorrectly. In this case we want
to keep symbol and than inline it during target llvm ir optimisation.

See also: #521

Signed-off-by: Dmitrii Makarenko <dmitrii.makarenko@intel.com>
Devjiu added a commit that referenced this issue Jun 30, 2023
This commit is an initial step to remove warnings from build. Currently
it's focused on linux build.

Always_inline attribute warning works incorrectly. In this case we want
to keep symbol and than inline it during target llvm ir optimisation.

See also: #521

Signed-off-by: Dmitrii Makarenko <dmitrii.makarenko@intel.com>
Devjiu added a commit that referenced this issue Jun 30, 2023
This commit is an initial step to remove warnings from build. Currently
it's focused on linux build.

Always_inline attribute warning works incorrectly. In this case we want
to keep symbol and than inline it during target llvm ir optimisation.

See also: #521

Signed-off-by: Dmitrii Makarenko <dmitrii.makarenko@intel.com>
Devjiu added a commit that referenced this issue Jun 30, 2023
This commit is an initial step to remove warnings from build. Currently
it's focused on linux gcc configuration.

Always_inline attribute warning works incorrectly. In this case we want
to keep symbol and than inline it during target llvm ir optimisation.

See also: #521

Signed-off-by: Dmitrii Makarenko <dmitrii.makarenko@intel.com>
kurapov-peter pushed a commit that referenced this issue Jul 3, 2023
This commit is an initial step to remove warnings from build. Currently
it's focused on linux gcc configuration.

Always_inline attribute warning works incorrectly. In this case we want
to keep symbol and than inline it during target llvm ir optimisation.

See also: #521

Signed-off-by: Dmitrii Makarenko <dmitrii.makarenko@intel.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant