Skip to content
This repository has been archived by the owner on Jan 11, 2018. It is now read-only.

"Delete this build" does not stop the current build process #64

Open
claudiob opened this issue Jul 16, 2010 · 4 comments
Open

"Delete this build" does not stop the current build process #64

claudiob opened this issue Jul 16, 2010 · 4 comments

Comments

@claudiob
Copy link

I have integrity running with delayed_job, so at times I have 1 running build and some pending builds.

When I push "Delete this build" on the running build, the build disappears from the web interface, but its process is not killed. The process continues in the background, and the pending builds do not start until that process has ended.

Is this a bug, or this does not concern you? In my case, my tests can last more than 30 minutes, and if I find out that the running build is somehow "wrong", I would like to kill it immediately, in order to be replaced by the next one in the queue.

Thanks

@sr
Copy link
Member

sr commented Jul 17, 2010

yeah, it'd be nice but I am not too concerned about it

@zedtux
Copy link

zedtux commented Apr 18, 2011

Agree with claudiob.

Here, Rspec + Cucumber is about 1h and half.

@grahamc
Copy link
Contributor

grahamc commented Jul 14, 2011

I hear the concern, and have plans to investigate this myself. I'm going to keep it open, but tag it as low priority with regards to getting Integrity up to date with Gems, and passing tests.

@p
Copy link
Member

p commented Nov 14, 2013

Killing out of process workers is more complicated, but at least in process worker threads can be made to check a flag periodically and quit if their build is deleted.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants