Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Custom page on successful login #307

Closed
bartlettc22 opened this issue Jun 14, 2020 · 8 comments · May be fixed by #308
Closed

Feature request: Custom page on successful login #307

bartlettc22 opened this issue Jun 14, 2020 · 8 comments · May be fixed by #308
Labels
enhancement New feature or request

Comments

@bartlettc22
Copy link

Would like to see an option for adding custom HTML for the successful login page. Right now it says 'OK' but would like the option to be a little more descriptive.

@int128 int128 added the enhancement New feature or request label Jun 14, 2020
@int128
Copy link
Owner

int128 commented Jun 14, 2020

Thank you for your contribution! This looks good. Would you tell me the message in your use case? I want to change the default message more helpful.

See also #193 (comment).

@bartlettc22
Copy link
Author

I would put something like <p>Kubernetes login successful. You can now close this page.</p>

@bartlettc22
Copy link
Author

I can update it in #308 if you like that wording

@int128
Copy link
Owner

int128 commented Jun 21, 2020

Thank you for your PR. I think the custom option is overkill and it would be happy for every users to make the default page more descriptive. I just created #312 and please let me know if you have ideas.

@int128
Copy link
Owner

int128 commented Jul 23, 2020

@sfxworks I'd like to confirm the purpose of #308 (comment). Do you need this feature to show a custom page after authentication?

I think it would be nice if user can set a URL to be redirected after authentication, like:

- name: oidc
  user:
    exec:
      apiVersion: client.authentication.k8s.io/v1beta1
      args:
      - oidc-login
      - get-token
      - --oidc-issuer-url=https://accounts.google.com
      - --oidc-client-id=YOUR_CLIENT_ID
      - --auth-success-url=https://your-site.example.com/login-success.html
      command: kubectl

@sfxworks
Copy link

Correct! I would like to show users a success page. We are starting to work on a multi-tenant cluster so showing a login success page with a list of helpful resources (like example commands and links to support articles) would be nice for users new to kubectl.

@int128
Copy link
Owner

int128 commented Aug 2, 2020

Could you check the new version?
https://github.com/int128/kubelogin/releases/tag/v1.20.0

@int128
Copy link
Owner

int128 commented Sep 1, 2020

Now --open-url-after-authentication flag is available and the purpose of this feature is achieved. Please open a new feature request if needed.

@int128 int128 closed this as completed Sep 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants