Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SkipIssuerCheck option to kubelogin #1055

Open
hongkunyoo opened this issue Feb 26, 2024 · 0 comments
Open

Add SkipIssuerCheck option to kubelogin #1055

hongkunyoo opened this issue Feb 26, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@hongkunyoo
Copy link

Purpose of the feature (why)

I really liked this project. Thanks for your effort.
I would like an option SkipIssuerCheck to skip to issuer check if possible. For example, --skip-issuer-check.
The reason why for this option is, in my K8s environment, I want to expose OIDC provide endpoint only to in-cluster scope for certain users. Which means the OIDC provider endpoint should vary for some users.
For example,

  • A user group: https://oidc.mycluster.com (default)
  • B user group: http://SVC_NAME.NAMESPACE.svc.cluster.local (for some users)

However, the jwt issuer should be https://oidc.mycluster.com for both case. Since the jwt issuer and OIDC provider endpoint does not match, currently an error occurs. I want to avoid this case.

Would you kindly consider to add --skip-issuer-check option for such case?

Your idea (how)

Add SkipIssuerCheck option in gooidc Verifier.

SkipIssuerCheck: true

verifier := c.provider.Verifier(&gooidc.Config{ClientID: c.oauth2Config.ClientID, Now: c.clock.Now, SkipIssuerCheck: true})

I have checked it works well when I add this option. I could just use the downstream and add it only for myself but I'm wondering if it's possible to add an option to the upstream.

@hongkunyoo hongkunyoo added the enhancement New feature or request label Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant