Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Progress bar off by one #343

Open
dkarlovi opened this issue Mar 15, 2022 · 0 comments
Open

Progress bar off by one #343

dkarlovi opened this issue Mar 15, 2022 · 0 comments
Labels
Milestone

Comments

@dkarlovi
Copy link
Collaborator

Q A
Bug report? yes
Feature request? no
BC Break report? no
RFC? no
Branch? master

I have just one data row in my Excel file, the other one is the header. Progress bar says it imported 1/2 and it's complete.

We shouldn't count the header as a row, total should be number of rows found - 1.

@dkarlovi dkarlovi added the bug label Mar 15, 2022
@dkarlovi dkarlovi added this to the 4.0.0 milestone Apr 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant