Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE]: Reduce config files #1033

Open
2 tasks
WiemKhlifi opened this issue Feb 20, 2024 · 0 comments
Open
2 tasks

[FEATURE]: Reduce config files #1033

WiemKhlifi opened this issue Feb 20, 2024 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@WiemKhlifi
Copy link
Contributor

WiemKhlifi commented Feb 20, 2024

Please describe the purpose of the feature. Is it related to a problem?

Integrate the systems' logger default into a single yaml file and move the common training controlling flags from systems files into the arch yaml files (e.g. seed and total_timesteps). This helps avoid setting things in each system in case we want to run a sweep for example and avoid adding a logger_default for each system.

Describe the solution you'd like

Loggers merged in one file and setting the common training flags outside each system 😄

How do we know when the implementation of this feature is complete?

Checklist:

  • Merge the logger files into one yaml file and add the system_name in the logger.py code by using the tags.append(system.system_name).
  • Add the common items related to training all systems in the arch files such as seed, total_timesteps, and num_updates.

Additional context

Check this PR #987 for some inspiration (An example was started in this PR but for now, we keep the systems' default separate) 🙌

🌟 Additional request: Merge system defaults for the same system type (such PPOs) and find the best way to select the system config without changing the default.

@WiemKhlifi WiemKhlifi added the enhancement New feature or request label Feb 20, 2024
@WiemKhlifi WiemKhlifi self-assigned this Feb 20, 2024
@WiemKhlifi WiemKhlifi changed the title [FEATURE] [FEATURE]: Reduce config files Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant