You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Please describe the purpose of the feature. Is it related to a problem?
Integrate the systems' logger default into a single yaml file and move the common training controlling flags from systems files into the arch yaml files (e.g. seed and total_timesteps). This helps avoid setting things in each system in case we want to run a sweep for example and avoid adding a logger_default for each system.
Describe the solution you'd like
Loggers merged in one file and setting the common training flags outside each system 😄
How do we know when the implementation of this feature is complete?
Checklist:
Merge the logger files into one yaml file and add the system_name in the logger.py code by using the tags.append(system.system_name).
Add the common items related to training all systems in the arch files such as seed, total_timesteps, and num_updates.
Additional context
Check this PR #987 for some inspiration (An example was started in this PR but for now, we keep the systems' default separate) 🙌
🌟 Additional request: Merge system defaults for the same system type (such PPOs) and find the best way to select the system config without changing the default.
The text was updated successfully, but these errors were encountered:
Please describe the purpose of the feature. Is it related to a problem?
Integrate the systems' logger default into a single yaml file and move the common training controlling flags from systems files into the arch yaml files (e.g.
seed
andtotal_timesteps
). This helps avoid setting things in each system in case we want to run a sweep for example and avoid adding a logger_default for each system.Describe the solution you'd like
Loggers merged in one file and setting the common training flags outside each system 😄
How do we know when the implementation of this feature is complete?
Checklist:
system_name
in the logger.py code by using thetags.append(system.system_name)
.Additional context
Check this PR #987 for some inspiration (An example was started in this PR but for now, we keep the systems' default separate) 🙌
🌟 Additional request: Merge system defaults for the same system type (such PPOs) and find the best way to select the system config without changing the default.
The text was updated successfully, but these errors were encountered: