Fix threaded reply, threaded react, and some private message things #181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zachdecook
changed the title
zachdecook
commented
Aug 30, 2022
| @@ -101,7 +101,7 @@ func (c *Channel) IsPublicChannel() bool { | |||
|
|
|||
| // IsPrivateChannel returns true if the channel is private. | |||
| func (c *Channel) IsPrivateChannel() bool { | |||
| return c.IsGroup && c.IsPrivate | |||
| return (c.IsGroup || c.IsChannel) && c.IsPrivate | |||
There was a problem hiding this comment.
I'm often missing messages from others (reactions come in fine) in these such private channels (that it had trouble joining before this change), so I wonder if something else needs to change here.
|
In case this has been forgotten or overlooked: this branch solved my problems with private channels as well. Been using it for a few days. I can check over the next few days whether I seem to be missing messages from these private channels, but for now until this is merged I will run this fork. Thank you for this effort @zachdecook :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All of my "day 1" bugs using this.
Fixes #180 and half of #168
Also Fixes #178