Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drawing seems to cause the screen elements to flicker #81

Open
jbmorley opened this issue Jan 25, 2022 · 3 comments
Open

Drawing seems to cause the screen elements to flicker #81

jbmorley opened this issue Jan 25, 2022 · 3 comments
Labels
bug Something isn't working
Milestone

Comments

@jbmorley
Copy link
Collaborator

This is particularly pronounced in Tile Fall. It might be a Tile Fall bug, but we should investigate.

@jbmorley jbmorley added this to the Future milestone Jan 28, 2022
@tomsci
Copy link
Collaborator

tomsci commented Feb 20, 2022

Also very noticeable on the paddle in Super Breakout, in addition to the balls not redrawing right, which is probably #121

@jbmorley jbmorley added the bug Something isn't working label Feb 21, 2022
@tomsci
Copy link
Collaborator

tomsci commented Feb 23, 2022

The issue with Tile Fall can be explained by the fact that TBarInit is supposed to call gUPDATE OFF before it returns, and our impl isn't doing that. Having fixed that there is much less flicker in Tile Fall, and the remainder is probably just hidden (on the Series 5 R1 at least) by the crazy amount of persistence of the LCD panel.

Breakout is a whole different ball game however.

@tomsci
Copy link
Collaborator

tomsci commented Mar 6, 2022

Another cause of flicker was that gLOADBIT and a couple of other commands would always trigger the equivalent of a gUPDATE(). I partially fixed this in 7c522c2 after determining it wasn't actually necessary in a couple of those cases. It is still necessary in eg gCLOSE to ensure graphics ops that copy across drawables don't get orphaned. We could remove that too with enough cunningness but I'm not sure if it's actually causing any problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants