Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

See whether rate limiting the event queue (or adding a maximum length) improves performance #165

Open
jbmorley opened this issue Feb 4, 2022 · 3 comments
Milestone

Comments

@jbmorley
Copy link
Collaborator

jbmorley commented Feb 4, 2022

No description provided.

@jbmorley
Copy link
Collaborator Author

jbmorley commented Feb 4, 2022

A maximum length might make it hard to guarantee boundaries (pen down, pen up, etc) aren't dropped on the floor.

@jbmorley
Copy link
Collaborator Author

jbmorley commented Feb 5, 2022

I took a quick look at this and I couldn't see any obvious way of receiving key repeats when using the pressesBegan, etc API. That suggests to me that we'll need to build our own key repeat mechanism. Nice thing about that is we get to control the key repeat speed (I think it was actually configurable on the Psion), and we can have the same key repeat for all device types (controllers, etc).

@jbmorley
Copy link
Collaborator Author

jbmorley commented Feb 5, 2022

Given the amount of work involved here, I'm going to push this into Future unless we find a good reason to bring it back.

@jbmorley jbmorley added this to the Future milestone Feb 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant