Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

specify display unit for save_kmz_timeseries.py #844

Open
1 of 2 tasks
pbrotoisworo opened this issue Sep 10, 2022 · 2 comments
Open
1 of 2 tasks

specify display unit for save_kmz_timeseries.py #844

pbrotoisworo opened this issue Sep 10, 2022 · 2 comments

Comments

@pbrotoisworo
Copy link
Contributor

Description of the desired feature

Can we add a parameter to change the display unit for save_kmz_timeseries.py. I notice that save_kmz.py has an argument for unit but I do not see the same option for save_kmz_timeseries.py. It is hard coded to be centimeters only.

Is your feature request related to a problem? Please describe

Describe the solution you'd like
Add display unit argument in save_kmz_timeseries.py

Describe alternatives you have considered

Additional context

Are you willing to help implement and maintain this feature?

  • Yes
  • No
@yunjunz
Copy link
Member

yunjunz commented Sep 11, 2022

HI @pbrotoisworo, this sounds good to me. Please feel free to go ahead and implement it.

As you may have seem that save_kmz_timeiseries is much complicated than save_kmz, so please ensure all the units of velocties and time-series displacements are converted. And don't hesitate to let me know if you have questions.

@EJFielding
Copy link

The default units of "cm" for save_kmz.py -v should be better specified in the help. I don't run it often, and I keep forgetting that it uses centimeters while the regular view.py -v units are meters and it is not obvious in the help usage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants