You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
馃悰 BUG: flex prop fails to interpret numeric arguments presented as strings properly as numbers - a single entry in columnData as a string causes the entire flex to fail.
#414
Open
LeadDreamer opened this issue
Mar 16, 2024
· 0 comments
What you did:
I use a form-driven system to format table columns - so that the data source defines it's column needs. I add the ability (in the string used to define the table formatting) to add extra props to the columnData - such as textarea:{flex=6}, where "textarea" defines an area to display a long string (preferably with wrap), and the "{}" wrapped string interpreted as a "&" seprated set of props and values.
What happened:
In other systems (of my own) where I have used this pattern, CSS interprets as a number any string that can be treated as a number.
In reactdatagrid, the value must be presented as a number. This makes it difficult to generalize by prop-insertion-options for reactdatagrid.
You can use reactdevtools in the browser to change the flex settings on the column data.
Problem description:
CSS interprets flex setting strings as numbers if possible.
reactdatagrid "simulates" flex, but does not interpret flex setting strings as numbers.
This behavior is inconsistent and will lead to strange bugs.
Suggested solution:
Follow the CSS flex standard and interpret flex setting strings as numbers.
The text was updated successfully, but these errors were encountered:
馃悰 Bug:
@inovua/reactdatagrid-enterprise
- version 5.10.2What you did:
I use a form-driven system to format table columns - so that the data source defines it's column needs. I add the ability (in the string used to define the table formatting) to add extra props to the columnData - such as
textarea:{flex=6}
, where "textarea" defines an area to display a long string (preferably with wrap), and the "{}" wrapped string interpreted as a "&" seprated set of props and values.What happened:
In other systems (of my own) where I have used this pattern, CSS interprets as a number any string that can be treated as a number.
In reactdatagrid, the value must be presented as a number. This makes it difficult to generalize by prop-insertion-options for reactdatagrid.
image if flex="6" is used:
image if flex=6 is used:
Reproduction repository:
https://github.com/SaltSweetSpirits/reactdatagrid_bug_example
Reproduction CodeSandBox:
https://codesandbox.io/p/github/SaltSweetSpirits/reactdatagrid_bug_example/main
You can use reactdevtools in the browser to change the flex settings on the column data.
Problem description:
CSS interprets flex setting strings as numbers if possible.
reactdatagrid "simulates" flex, but does not interpret flex setting strings as numbers.
This behavior is inconsistent and will lead to strange bugs.
Suggested solution:
Follow the CSS flex standard and interpret flex setting strings as numbers.
The text was updated successfully, but these errors were encountered: