Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nbtutor - separate out the visualisation window into a floating dialog? #4

Open
2 tasks
psychemedia opened this issue May 6, 2020 · 1 comment
Open
2 tasks
Labels
enhancement New feature or request

Comments

@psychemedia
Copy link
Contributor

psychemedia commented May 6, 2020

The nbtutor visualisation appears in the code cell that the nbtutor magic is running it. With the notebook layout split into a two column view, this makes things cramped when using nbtutor.

Possible solutions:

  • button to toggle "two column" vs normal single column layout;
  • floating nbtutor visualisation panel. (At the moment, the visualiser is inside a div with a unique id and class nbtutor-canvas)

Re: floating the panel, could it be floated like the nbev3devsim widget in a JQuery dialog widget?

@psychemedia
Copy link
Contributor Author

psychemedia commented May 6, 2020

Inspecting the widget, we can extract the visualisation div id and then open it as a dialog using a proof of concept such as:

%%HTML
<script>$( "#SPECIFIC_ID" ).dialog()</script>

We can perhaps then address rig this to be always the case in the src:

https://github.com/lgpage/nbtutor/blob/07798a044cf6e1fd4eaac2afddeef3e13348dbcd/src/es6/notebook/notebook.es6#L49

The nbtutor package doesn't install directly from the repo - it requires a build step first - so doing a quick test of the above tweak is fiddly...

@psychemedia psychemedia added the enhancement New feature or request label Jun 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant