Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from embroider_* to namespaced attributes #201

Closed
lexelby opened this issue Jun 16, 2018 · 4 comments
Closed

Switch from embroider_* to namespaced attributes #201

lexelby opened this issue Jun 16, 2018 · 4 comments
Labels
feature request Tag single request for new features with this medium

Comments

@lexelby
Copy link
Member

lexelby commented Jun 16, 2018

Currently, Ink/Stitch stores embroidery parameters as extra attributes on the path tags, for example embroider_running_stitch_length. I did that before I knew that XML has real namespacing built into it, and namespaces are commonly used to annotate SVGs with extra information.

Ink/Stitch uses namespaced tags in the <svg:metadata>, in part because the SVG spec requires that all tags inside the <svg:metadata> tag be in other namespaces.

Switch to using namespaced attributes such as inkstitch:running_stitch_length. Ink/Stitch should understand both the old and new style and convert from non-namespaced to namespaced any time the user runs Params.

@lexelby
Copy link
Member Author

lexelby commented Jun 16, 2018

discussed in #200

@lexelby lexelby added feature request Tag single request for new features with this medium labels Jun 16, 2018
@X3msnake
Copy link
Member

X3msnake commented Jun 16, 2018 via email

@lexelby
Copy link
Member Author

lexelby commented Jun 16, 2018

There's really no reason to do so. There will be no user-discernable change.

@X3msnake
Copy link
Member

@lexelby ok,

As long as you sure nothing can go wrong with the user file and destroy it, no warning needed then. I would still think it would be advisable for the user to know and do a save as.

But i leave this to your judgement since i dont have a full understanding of the implementation mechanism :)

@X3msnake X3msnake changed the title switch from embroider_* to namespaced attributes Switch from embroider_* to namespaced attributes Jun 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Tag single request for new features with this medium
Projects
None yet
Development

No branches or pull requests

3 participants