Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i-button voice control not working, breaking accessibility #327

Open
simondib opened this issue Oct 26, 2022 · 1 comment
Open

i-button voice control not working, breaking accessibility #327

simondib opened this issue Oct 26, 2022 · 1 comment
Labels
bug Issues that represent a bug.

Comments

@simondib
Copy link
Contributor

simondib commented Oct 26, 2022

  • What is the expected and current behavior?
    Voice control should be able to "click" a button (IButton)

  • Steps to reproduce

  1. Install "Handsfree for web" voice control Chrome extension and enable plugin
  2. Go to https://storybook.inkline.io/iframe.html?args=&id=components-button--basic&viewMode=story
  3. Say "click" and notice the button numbered control does not appear. An accessible voice-controllable button should normally appear as show:

image

  • Please tell us about your environment:

    • Version: =3.1.8
    • Browser: Chrome 106.0.5249.119
    • Language: TypeScript
  • Other information
    Detailed explanation, stacktraces, related issues, suggestions how to fix, links for us to have context, eg. stackoverflow, gitter, etc.

    Removing aria-disabled="false" from the IButton source seems to allow the button to be voice controlled, although removing it might have other implications.

@simondib simondib added the bug Issues that represent a bug. label Oct 26, 2022
@simondib simondib changed the title IButton voice control not working, breaking accessibility i-button voice control not working, breaking accessibility Nov 2, 2022
@alexgrozav
Copy link
Member

Thank you for reporting this. Probably removing the aria-disabled property altogether when it's disabled would work. I'll take care of it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issues that represent a bug.
Projects
None yet
Development

No branches or pull requests

2 participants