Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do something about punycode deprecation warning #1343

Closed
bugarela opened this issue Jan 16, 2024 · 3 comments · Fixed by #1380
Closed

Do something about punycode deprecation warning #1343

bugarela opened this issue Jan 16, 2024 · 3 comments · Fixed by #1380
Assignees
Labels
tech-debt Technical debt

Comments

@bugarela
Copy link
Collaborator

From Node 21, one of our indirect dependencies (punycode) is deprecated. We should deal with that.

This is the warning that is shown when someone calls our CLI with node 21:

(node:2145150) [DEP0040] DeprecationWarning: The `punycode` module is deprecated. Please use a userland alternative instead.
(Use `node --trace-deprecation ...` to show where the warning was created)
@bugarela bugarela added the tech-debt Technical debt label Jan 16, 2024
@shonfeder
Copy link
Contributor

These have become errors now, the debt collector came calling :)

@shonfeder shonfeder self-assigned this Feb 27, 2024
@shonfeder
Copy link
Contributor

We are pulling in the problematic use of punycode thru the node-fetch dependency, and hitting node-fetch/node-fetch#1797

This should be fixed in node-fetch v3, but there are some breaking API changes we'll have to account for.

@shonfeder
Copy link
Contributor

Not only do we have breaking changes in the node-fetch that fixes this depreciation issue, but also typescript compatibility has been lost with the latest version, node-fetch/node-fetch#1617

Dropping this dependency would be the best option, I think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tech-debt Technical debt
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants