Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SOHO-8073: [IE11, Chrome] Editor - Styling can be applied on white-space characters #390

Closed
clepore opened this issue Jul 17, 2018 · 6 comments

Comments

@clepore
Copy link
Contributor

clepore commented Jul 17, 2018

Users should not be able to apply some of the font styling on white-space characters. i.e. the user pressed space or tab and selected that white space and applied Underline or Strikethrough on it.
It is expected that whitespace cannot have font styling applied on it. Other formatting could be acceptable, such as indentation.

styling on whitespace

@tmcconechy tmcconechy added the [3] Velocity rating (Fibonacci) label Jul 18, 2018
@davidcarlsonberg
Copy link
Contributor

davidcarlsonberg commented Jan 9, 2019

@clepore To clarify, if user highlights ONLY whitespace, styling should not apply? But if user highlights a block of text that has characters AND whitespace, styling should apply? I ask because in Word, whitespace is actually allowed if whitespace occurs inside a character string.

whitespace

@clepore
Copy link
Contributor Author

clepore commented Jan 9, 2019

I'm not really sure. I converted these tickets over from JIRA SOHO-8173, so that's why it looks like I submitted this one.

I would personally feel that you can format whatever you want, even if it is whitespace.

@davidcarlsonberg
Copy link
Contributor

davidcarlsonberg commented Jan 9, 2019

I have a solution to disallow styling when the highlighted selection is only whitespace.

@EdwardCoyle
Copy link
Contributor

I think @davidcarlsonberg’s assessment is correct - that only highlighting whitespace should result in no formatting applied, but whitespace inside of text characters should have formatting applied

@deep7102
Copy link
Contributor

deep7102 commented Jan 9, 2019

I agree with @davidcarlsonberg and @EdwardCoyle

@davidcarlsonberg
Copy link
Contributor

Closing after discussion because "it seems logical and expected" as currently implemented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Development

No branches or pull requests

5 participants