Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiselect: Select All checkbox should only select visible (filtered) items #3845

Closed
hohnzy opened this issue Apr 30, 2020 · 13 comments · Fixed by #4037
Closed

Multiselect: Select All checkbox should only select visible (filtered) items #3845

hohnzy opened this issue Apr 30, 2020 · 13 comments · Fixed by #4037
Assignees
Labels
team: ion Issues for the ion team(s) type: bug 🐛 [5] Velocity rating (Fibonacci)

Comments

@hohnzy
Copy link

hohnzy commented Apr 30, 2020

Is your feature request related to a problem or use case? Please describe.
selectAll option in dropdown component should select only what is currently in the list when filter is applied

Describe the solution you'd like
An option for selectAll to select everything or filtered list.

Describe alternatives you've considered
adding new parameter 'selectFiltered'

Additional context
CZONaYdpUt

@tmcconechy tmcconechy added [2] Velocity rating (Fibonacci) type: bug 🐛 [3] Velocity rating (Fibonacci) team: ion Issues for the ion team(s) and removed [2] Velocity rating (Fibonacci) labels Apr 30, 2020
@tmcconechy tmcconechy added this to To do in Enterprise 4.30.x (June 2020) Sprint via automation Apr 30, 2020
@EdwardCoyle
Copy link
Contributor

@tmcconechy is this a different feature you think? Should we make this configurable and leave the current behavior as the other option?

@tmcconechy
Copy link
Member

I feel like this should be the correct behavior but open to debate. So thinking make an option selectAllFilterOnly or whatever and set it to true by default

@thomas-blackwell
Copy link

Any progress on this issue?

@EdwardCoyle
Copy link
Contributor

EdwardCoyle commented May 5, 2020

@thomas-blackwell we have this issue scheduled for our June sprint, starting June 1

@tmcconechy tmcconechy added [5] Velocity rating (Fibonacci) and removed [3] Velocity rating (Fibonacci) labels Jun 1, 2020
@EdwardCoyle EdwardCoyle self-assigned this Jun 9, 2020
@EdwardCoyle EdwardCoyle moved this from To do to In progress in Enterprise 4.30.x (June 2020) Sprint Jun 9, 2020
@EdwardCoyle EdwardCoyle changed the title Dropdown - the select all should select only visible (filtered) items Multiselect: Select All checkbox should only select visible (filtered) items Jun 9, 2020
@tmcconechy tmcconechy moved this from In progress to Pending Review in Enterprise 4.30.x (June 2020) Sprint Jun 12, 2020
@tmcconechy tmcconechy moved this from Pending Review to Ready for QA (beta) in Enterprise 4.30.x (June 2020) Sprint Jun 17, 2020
@jbrcna
Copy link
Contributor

jbrcna commented Jun 18, 2020

@jbrcna
Copy link
Contributor

jbrcna commented Jun 18, 2020

just some observation in Uplift Theme
image

@jbrcna jbrcna moved this from Ready for QA (beta) to Done in Enterprise 4.30.x (June 2020) Sprint Jun 18, 2020
@EdwardCoyle
Copy link
Contributor

EdwardCoyle commented Jun 18, 2020

@jbrcna Looks like @janahintal raised #4055 for this. I'm addressing in #4056, should be fixed after we merge that

@AsafMeirBarziv
Copy link

Can this fix be applied on datagrid too?

@tmcconechy
Copy link
Member

I dont think this issue has anything to do with datagrid specifically as it is around the lookup components functionality?

@AsafMeirBarziv
Copy link

AsafMeirBarziv commented Mar 30, 2021 via email

@tmcconechy
Copy link
Member

OK, that would be a separate issue... But i don't get it so maybe need some steps, closest I can think of is:

https://master-enterprise.demo.design.infor.com/components/datagrid/example-multiselect.html

  • apply a filter
  • select all
  • revert the filter
  • only what was filtered is selected

This issue relates to lookup and no further work will be done on it here.

@AsafMeirBarziv
Copy link

AsafMeirBarziv commented Mar 30, 2021 via email

@tmcconechy
Copy link
Member

Yes, if you have an issue - this is closed nothing further is being done here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team: ion Issues for the ion team(s) type: bug 🐛 [5] Velocity rating (Fibonacci)
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

6 participants