Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EmptyMessage: Text needs to be more subtle #3476

Closed
jamie-norman opened this issue Feb 11, 2020 · 19 comments · Fixed by #3725
Closed

EmptyMessage: Text needs to be more subtle #3476

jamie-norman opened this issue Feb 11, 2020 · 19 comments · Fixed by #3725
Assignees
Labels
design Needs input from IDS Design Team team: landmark For Landmark issues [2] Velocity rating (Fibonacci)

Comments

@jamie-norman
Copy link

Is your feature request related to a problem? Please describe.
In general, the empty state messaging beneath the icons is too heavy, being displayed in 2.2rem source sans semibold. What we're seeing is that empty states often call too much attention to themselves and pull the eye away from more meaningful or priority information

Describe the solution you'd like
Consider either lightening the text color, maybe .7 opacity and/or make the font weight regular with similar lightening or decrease in opacity

image

@tmcconechy tmcconechy added [2] Velocity rating (Fibonacci) design Needs input from IDS Design Team team: landmark For Landmark issues labels Feb 11, 2020
@tmcconechy
Copy link
Member

@jamie-norman
Copy link
Author

Could be simple as adding the Source Sans Ultra Light or Light to the stack...
image

@tmcconechy
Copy link
Member

Maybe a color change or font-weight change? Adding another download for the font seems like it would cut some performance. If we can avoid downloading a new font-set would like to do that.

@jamie-norman
Copy link
Author

Fair. Somewhere between 40-60% opacity could work.
image

@kentonquatman
Copy link

Screen Shot 2020-02-11 at 3 52 05 PM

I took a look at this using the card example on the IDS website and noticed that the card titles and empty messages are using type sizes from the outdated type scale. This will be a good opportunity to fix a few items at once.

  • Card title: reduce to 20 (2.0rem)
  • Empty message: reduce to 16 (1.6rem), change to Slate-06 (#606066)

@tmcconechy tmcconechy added this to To do in Enterprise 4.28.x (April 2020) Sprint via automation Feb 11, 2020
@kentonquatman
Copy link

kentonquatman commented Feb 11, 2020

@jamie-norman Let me know if that proposed solution would work for your use case or if it's still to heavy on the page.

@jamie-norman
Copy link
Author

@kentonquatman Yes, I think that could be an option. We don't seem to use the secondary text in most case.

@jamie-norman
Copy link
Author

@tmcconechy Still planning on this one for April? At least one solution consultant noted that an empty state appeared to him like an error. I suspect some of that has to do with their visual weight, so hoping the proposed solution will find a better balance between an alert and something more informational. It will also be a change cycle for folks that are used to the old empty states, which were just text in the list footer.

@tmcconechy
Copy link
Member

tmcconechy commented Mar 11, 2020

I put this in the end of the april (next sprint). But we can move it. What is the proposed solution though i see several here? I think that needs clarification... cc @inforandy

@jamie-norman
Copy link
Author

I don't think we need to rush or re-prioritize. But I agree, we need some clarity. @kevinwhitedesign do we want to make a design decision?

@kevinwhitedesign
Copy link

@jamie-norman Yeah I see this issue pretty clearly. This 'empty state' component was started with the intention that there would be titles, descriptions and actions. So just having the title throws off the visual weight here, we probably should have designed this with one-line from the beginning. I'll get to an example tomorrow.

@kevinwhitedesign
Copy link

kevinwhitedesign commented Apr 1, 2020

It looks like we're really emphasizing 'No Data Available' across the board here, while landmark probably has a slew of these instances. I wonder if it would be of interest to swap the title for body text here to achieve a more subtle description of what's going on? Thoughts @tmcconechy @jamie-norman ?
icon-typelockup

@tmcconechy
Copy link
Member

Works for me. Can you show the suggestion with the optional additional informational text? Also is the icon the same size or should we reduce that (feel like its pretty big = emphasis)

@jamie-norman
Copy link
Author

Not sure I follow, Kev. Are you suggesting in your example above that "Data Lake" becomes "No data Available?"
Also agree with Tim that reducing the size of the empty state icon seems reasonable too.

@kevinwhitedesign
Copy link

kevinwhitedesign commented Apr 1, 2020

One caveat was I had an icon size that was larger than Tim's production code. I had 150, he had 100. Now that that's cleared up:

I went down to 80px. This feels appropriate to me.

@jamie-norman data lake was just silly filler text for the card title.
empty-state-typography

@tmcconechy
Copy link
Member

Looks much better to me.

@jamie-norman
Copy link
Author

@kevinwhitedesign Gotcha. I like those options—definitely in line with what I was thinking. The outlines of the icon itself could even be lighter.

@kevinwhitedesign
Copy link

Yep, something was wrong with my svgs actually. Fixed.

empty-state-typography-2

@tmcconechy tmcconechy changed the title Empty state text needs to be more subtle EmptyMessage: Text needs to be more subtle Apr 1, 2020
@jmacaluso711 jmacaluso711 self-assigned this Apr 7, 2020
@jmacaluso711 jmacaluso711 moved this from To do to In progress in Enterprise 4.28.x (April 2020) Sprint Apr 7, 2020
@tmcconechy tmcconechy moved this from In progress to Pending Review in Enterprise 4.28.x (April 2020) Sprint Apr 9, 2020
@tmcconechy tmcconechy moved this from Pending Review to Ready for QA (beta) in Enterprise 4.28.x (April 2020) Sprint Apr 13, 2020
@jbrcna
Copy link
Contributor

jbrcna commented Apr 14, 2020

QA Passed.
v4.28.0-dev

@jbrcna jbrcna moved this from Ready for QA (beta) to Done in Enterprise 4.28.x (April 2020) Sprint Apr 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design Needs input from IDS Design Team team: landmark For Landmark issues [2] Velocity rating (Fibonacci)
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

6 participants