Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fileupload: Modal dialog can disappear when tabbing #3458

Closed
fitzorama opened this issue Feb 7, 2020 · 3 comments · Fixed by #3461
Closed

Fileupload: Modal dialog can disappear when tabbing #3458

fitzorama opened this issue Feb 7, 2020 · 3 comments · Fixed by #3461
Assignees
Labels
priority: critical team: landmark For Landmark issues type: bug 🐛 [2] Velocity rating (Fibonacci)

Comments

@fitzorama
Copy link

fitzorama commented Feb 7, 2020

Describe the bug
When a file upload control is used on modal dialog and there are sufficient (many) fields, tabbing through the file upload control will cause the modal dialog to disappear or cause it to partially display.

The test below has been modified to have additional fields on the modal.
test-fileupload.zip

To Reproduce
Steps to reproduce the behavior:

  1. Unzip the above file and replace \app\views\components\modal\test-fileupload.html
  2. Go to http://localhost:4000/components/modal/test-fileupload.html
  3. Click on the Show Modal button
  4. The modal should display and focus should be in the first field
  5. Using the tab key, tab through all the fields; the file upload field is the last field
  6. Modal dialog disappears when tabbing out of the file upload field
  7. Shift-tab will cause the modal to reappear, although it is not placed correctly on the screen

Expected behavior
Expect the first button of the dialogs buttons to receive focus next.

Version

  • ids-enterprise: 4.25.1

Screenshots
file-upload-tab-index-issue

Platform

  • all

Additional context
Add any other context about the problem here.

@tmcconechy tmcconechy added the [2] Velocity rating (Fibonacci) label Feb 7, 2020
@fitzorama
Copy link
Author

@tmcconechy We will need a patch for 4.25.1.

@tmcconechy
Copy link
Member

@fitzorama created a 4.25.2 with this fix and a corresponding 6.4.2 release of NG. Both now in npm

@tmcconechy tmcconechy moved this from In progress to Ready for QA (beta) in Enterprise 4.26.x (January/Feb 2020) Sprint Feb 10, 2020
@brianjuan
Copy link

Passed QA in all browsers, tested in http://master-enterprise.demo.design.infor.com/components/modal/test-fileupload-scroll.html. Will retest once beta is deployed.

@brianjuan brianjuan moved this from Ready for QA (beta) to Done in Enterprise 4.26.x (January/Feb 2020) Sprint Feb 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: critical team: landmark For Landmark issues type: bug 🐛 [2] Velocity rating (Fibonacci)
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

4 participants