Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Datagrid: Lookup icon overlaps text #3160

Closed
tobywicksinfor opened this issue Nov 20, 2019 · 4 comments
Closed

Datagrid: Lookup icon overlaps text #3160

tobywicksinfor opened this issue Nov 20, 2019 · 4 comments
Assignees
Labels
focus: datagrid Main focus is Datagrid type: bug 🐛 [2] Velocity rating (Fibonacci)

Comments

@tobywicksinfor
Copy link
Contributor

Describe the bug
The lookup/search icon displayed in a lookup data grid cell can overlap the text in the cell when the column width is smaller than the width of the text.

To Reproduce
Steps to reproduce the behavior:

  1. npm run start
  2. http://localhost:4000/components/datagrid/test-editable-lookup.html

Expected behavior
The text is shortened (and potentially an ellipsis displayed) so that the lookup and text do not overlap.

Version
IDS Enterprise Components - v4.24.0-dev

Screenshots
Datagrid lookup cell overlaps text

Platform

  • OS Version: Windows 10 OS Version 1809
  • Browser Name: Chrome
  • Browser Version: 78.0.3904.97 (Official Build) (64-bit) (cohort: Stable)

Additional context
Perhaps related to #2174 and/or #2270.

@jbrcna
Copy link
Contributor

jbrcna commented Jan 27, 2020

The issue still persists when you just resize the column. if you edit the lookup field (product id) , it aligns accordingly
verified in https://4250-rc1-enterprise.demo.design.infor.com/components/datagrid/test-editable-lookup.html
image
also, there's another observation and filed as a separate issue. #3386

@jbrcna jbrcna moved this from Ready for QA (rc) to Failed QA (rc) in Enterprise 4.25.x (December 2019) Sprint Jan 27, 2020
@tmcconechy tmcconechy moved this from Failed QA (rc) to In progress in Enterprise 4.25.x (December 2019) Sprint Jan 27, 2020
@tmcconechy
Copy link
Member

To be clear , im only able to make this fix for edit mode. Its not possible for non edit mode (hover).
But can check. We possibly punt on this last issue

@tmcconechy
Copy link
Member

Pushing a change for rc 2 - that uses the ellipsis setting so it will flow to ellipsis now.

@jbrcna
Copy link
Contributor

jbrcna commented Jan 29, 2020

The issue is now resolved. tagging this ticket as PASSED and DONE
Verified https://4250-rc2-enterprise.demo.design.infor.com/components/datagrid/test-editable-lookup.html

@jbrcna jbrcna moved this from Ready for QA (rc) to Done in Enterprise 4.25.x (December 2019) Sprint Jan 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
focus: datagrid Main focus is Datagrid type: bug 🐛 [2] Velocity rating (Fibonacci)
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

3 participants